Skip to content

[PWGHF] trackIndexSkimCreator: Avoid slicing inside the inner loop#16581

Merged
vkucera merged 2 commits into
AliceO2Group:masterfrom
ktf:pr16581
Jun 9, 2026
Merged

[PWGHF] trackIndexSkimCreator: Avoid slicing inside the inner loop#16581
vkucera merged 2 commits into
AliceO2Group:masterfrom
ktf:pr16581

Conversation

@ktf

@ktf ktf commented Jun 9, 2026

Copy link
Copy Markdown
Member

The bachelor track indices depend only on the collision, not on the
cascade, so slice them once per collision. Each sliceBy on this Filtered
join does a full arrow Table::Slice (per-column allocation) plus a
selection-vector slice, so rebuilding it for every cascade is pure waste.

@github-actions github-actions Bot added the pwghf PWG-HF label Jun 9, 2026
@github-actions github-actions Bot changed the title Avoid slicing inside the inner loop [PWGHF] Avoid slicing inside the inner loop Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 8 warnings, 🔕 7 disabled

Comment thread PWGHF/TableProducer/trackIndexSkimCreator.cxx Outdated
Comment thread PWGHF/TableProducer/trackIndexSkimCreator.cxx Outdated
@ktf ktf requested a review from vkucera June 9, 2026 13:04
@vkucera vkucera changed the title [PWGHF] Avoid slicing inside the inner loop [PWGHF] trackIndexSkimCreator: Avoid slicing inside the inner loop Jun 9, 2026
@vkucera vkucera merged commit 764a518 into AliceO2Group:master Jun 9, 2026
16 of 17 checks passed
@vkucera

vkucera commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Thanks @ktf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

2 participants