Skip to content

higher MB gaps for testing - #2515

Open
jaimenorman wants to merge 2 commits into
AliceO2Group:masterfrom
jaimenorman:master
Open

jaimenorman wants to merge 2 commits into
AliceO2Group:masterfrom
jaimenorman:master

Conversation

@jaimenorman

Copy link
Copy Markdown
Contributor

No description provided.

@jaimenorman
jaimenorman requested a review from a team as a code owner October 21, 2026 14:16
@github-actions

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@joonsukbae

joonsukbae commented Oct 27, 2026 •

Copy link
Copy Markdown

Hi @jaimenorman, thanks a lot for the quick PR right after JSUB discussion. The simulation test fails because of the test size. With the default 100 events, gap 9 gives 12 jet-jet events (events 0, 9, ..., 99) and gap 11 gives 10, outside the ±5 % window of the test macros (10.6–11.7 and 8.6–9.5). Gap 7 gives 15 and passes at the edge (13.6–15.0). With a multiple of the gap as the number of test events (98, 99, 99), all three give exactly 1/gap.

@jaimenorman

Copy link
Copy Markdown
Contributor Author

Thanks a lot @joonsukbae for spotting this, I have increased the tolerance in the check.
Though the simulation test is now failing for a different reason, looks to be an Alien token that has expired - @sawenzel @jackal1-66 could you check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants