Repository navigation
ITS/MFT digi: account BC reassignment in time wrt BC - #16016
Merged
Merged
Conversation
Fix from @atriolo: In continuous mode, if mCollisionTimeWrtROF < 0, the reference BC is moved one BC earlier to get the ROF ID it belongs to, but mCollisionTimeWrtROF is not increased by 24.95 ns to compensate for the shift of the reference BC: as a result the collision is placed 24.95 ns too early with respect to its ROF Also ITS3 digitization is fixed.
shahor02
requested review from
arossi81,
f3sch,
fgrosa,
fprino,
mconcas and
mcoquet642
as code owners
October 27, 2026 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix from @atriolo: In continuous mode, if mCollisionTimeWrtROF < 0, the reference BC is moved one BC earlier to get the ROF ID it belongs to, but mCollisionTimeWrtROF is not increased by 24.95 ns to compensate for the shift of the reference BC: as a result the collision is placed 24.95 ns too early with respect to its ROF
Also ITS3 digitization is fixed.