RICH: make local Z the radial axis for radiator and photosensor tiles#15503
Open
altsybee wants to merge 3 commits into
Open
RICH: make local Z the radial axis for radiator and photosensor tiles#15503altsybee wants to merge 3 commits into
altsybee wants to merge 3 commits into
Conversation
added 3 commits
June 9, 2026 21:36
Collaborator
Contributor
|
I confirm everything is ok. This can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
RICHRing.cxxtheTGeoArb8solids for the radiator tiles (radTile_*) and photosensor tiles (RICHPhotoTile) are redefined so their thin (radial) dimension is now the local Z axis, pointing radially outward from the IP, instead of local X. The placement rotation is changed fromRotateY(-thetaBDeg)toRotateY(90 - thetaBDeg)to compensate the X→Z swap. The tiles therefore stay in exactly the same physical position — only the local frame is relabeled — which lets downstream tooling (e.g. ACTS) use the local Z = surface-normal convention directly.argonSector_*is left unchanged, since its gap dimension is already on local Z.Verified numerically that the 8 world-space corners of every tile are identical before and after (zero displacement).
(Note that any code relying on the previous local-axis convention should be rechecked.)
@NNicassio99