Skip to content

perf(mpi): remove the serial O(R·S²) protocol floor from HybridComm - #166

Draft
diagonal-hamiltonian wants to merge 19 commits into
mainfrom
perf/multinode-comm-scaling
Draft

perf(mpi): remove the serial O(R·S²) protocol floor from HybridComm#166
diagonal-hamiltonian wants to merge 19 commits into
mainfrom
perf/multinode-comm-scaling

style(tests): 🎨 reflow two test messages for clang-format 21

fa65466
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Aug 13, 2026 in 1m 11s

Annotations

Check failure on line 162 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pm&open=AZ_xgzD_5Od82_2vs9Pm&pullRequest=166

Check failure on line 187 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture all local variables required in this lambda.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASE&open=AZ-tDxMiC20taTj0MASE&pullRequest=166

Check warning on line 81 in cpp/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::find" that takes a range.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASR&open=AZ-tDxSCC20taTj0MASR&pullRequest=166

Check failure on line 134 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pi&open=AZ_xgzD_5Od82_2vs9Pi&pullRequest=166

Check failure on line 134 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture all local variables required in this lambda.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pj&open=AZ_xgzD_5Od82_2vs9Pj&pullRequest=166

Check warning on line 431 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 10 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASF&open=AZ-tDxMiC20taTj0MASF&pullRequest=166

Check failure on line 144 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pk&open=AZ_xgzD_5Od82_2vs9Pk&pullRequest=166

Check warning on line 52 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this structure so it has no more than 20 fields, rather than the 34 it currently has.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MAR_&open=AZ-tDxMiC20taTj0MAR_&pullRequest=166

Check failure on line 298 in cpp/monoprop/detail/partition/CpuTopology.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_79mF_is02fnzk4rTk&open=AZ_79mF_is02fnzk4rTk&pullRequest=166

Check warning on line 288 in cpp/monoprop/detail/partition/CpuTopology.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce verbosity with "using enum" for "monoprop::detail::partition::NodeMask".

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_79mF_is02fnzk4rTj&open=AZ_79mF_is02fnzk4rTj&pullRequest=166

Check failure on line 253 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASP&open=AZ-tDxMiC20taTj0MASP&pullRequest=166

Check failure on line 178 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASM&open=AZ-tDxMiC20taTj0MASM&pullRequest=166

Check failure on line 203 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture all local variables required in this lambda.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pv&open=AZ_xgzD_5Od82_2vs9Pv&pullRequest=166

Check failure on line 209 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture all local variables required in this lambda.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pp&open=AZ_xgzD_5Od82_2vs9Pp&pullRequest=166

Check failure on line 250 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASO&open=AZ-tDxMiC20taTj0MASO&pullRequest=166

Check warning on line 325 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 9 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pr&open=AZ_xgzD_5Od82_2vs9Pr&pullRequest=166

Check warning on line 35 in cpp/monoprop/detail/mpi/CommProfile.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't mix public and private data members.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSaC20taTj0MASd&open=AZ-tDxSaC20taTj0MASd&pullRequest=166

Check warning on line 318 in cpp/monoprop/detail/partition/CpuTopology.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::find_if" that takes a range.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_79mF_is02fnzk4rTl&open=AZ_79mF_is02fnzk4rTl&pullRequest=166

Check warning on line 124 in cpp/monoprop/detail/mpi/PartitionBarrier.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSCC20taTj0MASS&open=AZ-tDxSCC20taTj0MASS&pullRequest=166

Check failure on line 435 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pu&open=AZ_xgzD_5Od82_2vs9Pu&pullRequest=166

Check failure on line 203 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pn&open=AZ_xgzD_5Od82_2vs9Pn&pullRequest=166

Check failure on line 187 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxMiC20taTj0MASD&open=AZ-tDxMiC20taTj0MASD&pullRequest=166

Check warning on line 126 in cpp/monoprop/detail/mpi/CommProfile.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "start_". Use the in-class initializer instead.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ-tDxSaC20taTj0MASe&open=AZ-tDxSaC20taTj0MASe&pullRequest=166

Check warning on line 249 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 9 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pq&open=AZ_xgzD_5Od82_2vs9Pq&pullRequest=166

Check failure on line 432 in cpp/monoprop/detail/mpi/HybridComm.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=Algorithmiq_monoprop&issues=AZ_xgzD_5Od82_2vs9Pt&open=AZ_xgzD_5Od82_2vs9Pt&pullRequest=166