Rebuild admin resource table frame - #4131
Open
tvdeyen wants to merge 4 commits into
Open
Conversation
Easier for new workspaces to setup what we need
The resource table wrapper should only wrap the table for overflowing/scroll behavior. All other nested components (sidebar/pagination) should live in the UI chrome. This moves the pagination out of the resource_table partial. If you have overwritten the partial for one of you resources please simply remove it or (if you also have overwritten the index template) move it into the index template.
The upload button needs a span for the input[type=file] to receive click event. We cannot use a `<button>` here.
In the rebuilt admin frame the picture thumbnail link collapsed to the rendered size of the thumbnail image, so a tiny image (such as the 1x1 test fixture or an unloaded image) left an unclickably small target. Letting the link and thumbnail fill the already-sized tile keeps the whole tile clickable regardless of the image's dimensions.
tvdeyen
force-pushed
the
rebuild-admin-frame
branch
from
August 5, 2026 21:24
22366fb to
687f046
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4131 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 351 351
Lines 9236 9236
=======================================
Hits 9077 9077
Misses 159 159 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
The resource table wrapper should only wrap the table
for overflowing/scroll behavior. All other nested
components (sidebar/pagination) should live in the
UI chrome.
Notable changes
This moves the pagination out of the
resource_tablepartial. If you have overwritten the partial for one
of you resources please simply remove it or (if you also
have overwritten the index template) move it into the
index template.
Checklist