-
Notifications
You must be signed in to change notification settings - Fork 692
Fix AUTOINCREMENT not populating identity columns in IndexedDB tables #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+77
−0
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| if (typeof exports === 'object') { | ||
| var assert = require('assert'); | ||
| var alasql = require('..'); | ||
| } else { | ||
| __dirname = '.'; | ||
| } | ||
|
|
||
| // IndexedDB tests only run in a browser environment | ||
| if (typeof exports != 'object') { | ||
| describe('Test 861 - AUTOINCREMENT for IndexedDB', function () { | ||
| it('1. AUTOINCREMENT column should be populated on INSERT', async () => { | ||
| const sql = alasql.promise; | ||
|
|
||
| await sql(` | ||
| CREATE INDEXEDDB DATABASE IF NOT EXISTS test861; | ||
| ATTACH INDEXEDDB DATABASE test861; | ||
| USE test861; | ||
| DROP TABLE IF EXISTS autoinctab; | ||
| CREATE TABLE IF NOT EXISTS autoinctab (aid INT AUTOINCREMENT, aname STRING); | ||
| `); | ||
|
|
||
| await sql('INSERT INTO autoinctab (aname) VALUES ("bar1"),("bar2")'); | ||
|
|
||
| const res = await sql('SELECT * FROM autoinctab'); | ||
|
|
||
| assert.deepStrictEqual(res, [ | ||
| {aid: 1, aname: 'bar1'}, | ||
| {aid: 2, aname: 'bar2'}, | ||
| ]); | ||
|
|
||
| await sql('DROP INDEXEDDB DATABASE test861'); | ||
| }); | ||
|
|
||
| it('2. AUTOINCREMENT continues incrementing across multiple INSERTs', async () => { | ||
| const sql = alasql.promise; | ||
|
|
||
| await sql(` | ||
| CREATE INDEXEDDB DATABASE IF NOT EXISTS test861b; | ||
| ATTACH INDEXEDDB DATABASE test861b; | ||
| USE test861b; | ||
| DROP TABLE IF EXISTS autoinctab2; | ||
| CREATE TABLE IF NOT EXISTS autoinctab2 (aid INT AUTOINCREMENT, aname STRING); | ||
| `); | ||
|
|
||
| await sql('INSERT INTO autoinctab2 (aname) VALUES ("row1")'); | ||
| await sql('INSERT INTO autoinctab2 (aname) VALUES ("row2")'); | ||
|
|
||
| const res = await sql('SELECT * FROM autoinctab2'); | ||
|
|
||
| assert.deepStrictEqual(res, [ | ||
| {aid: 1, aname: 'row1'}, | ||
| {aid: 2, aname: 'row2'}, | ||
| ]); | ||
|
|
||
| await sql('DROP INDEXEDDB DATABASE test861b'); | ||
| }); | ||
| }); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.