Skip to content

fix: row.cosine_similarity was always None on self-host #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobinXL merged 1 commit into from
Aug 26, 2026
Merged

fix: row.cosine_similarity was always None on self-host #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions agentx/evaluations/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from __future__ import annotations

from typing import Any, Dict, List, Literal, Optional, Union
from pydantic import BaseModel, Field, model_validator
from pydantic import AliasChoices, BaseModel, Field, model_validator

# ---------------------------------------------------------------------------
# Observable trace
Expand Down Expand Up @@ -418,7 +418,11 @@ class RunResultRow(BaseModel):
latency_ms: Optional[float] = Field(default=None, alias="latencyMs")
input_tokens: Optional[int] = Field(default=None, alias="inputTokens")
output_tokens: Optional[int] = Field(default=None, alias="outputTokens")
cosine_similarity: Optional[float] = Field(default=None, alias="cosineSimilarity")
# Self-host sends vectorSimilarity, the hosted platform cosineSimilarity - accept both
# (row.cosine_similarity was silently None forever on self-host before this).
cosine_similarity: Optional[float] = Field(
default=None, validation_alias=AliasChoices("cosineSimilarity", "vectorSimilarity")
)
jaccard_similarity: Optional[float] = Field(default=None, alias="jaccardSimilarity")
bleu_score: Optional[float] = Field(default=None, alias="bleuScore")
rouge_score: Optional[float] = Field(default=None, alias="rougeScore")
Expand Down Expand Up @@ -468,7 +472,11 @@ class ReportStatistics(BaseModel):
average_rating: float = Field(default=0.0, alias="averageRating")
min_rating: float = Field(default=0.0, alias="minRating")
max_rating: float = Field(default=0.0, alias="maxRating")
cosine_similarity: Optional[float] = Field(default=None, alias="cosineSimilarity")
# Self-host sends vectorSimilarity, the hosted platform cosineSimilarity - accept both
# (row.cosine_similarity was silently None forever on self-host before this).
cosine_similarity: Optional[float] = Field(
default=None, validation_alias=AliasChoices("cosineSimilarity", "vectorSimilarity")
)
jaccard_similarity: Optional[float] = Field(default=None, alias="jaccardSimilarity")
bleu_score: Optional[float] = Field(default=None, alias="bleuScore")
rouge_score: Optional[float] = Field(default=None, alias="rougeScore")
Expand Down
Loading