refactor(core): extract broker transport port - #47
Open
kjgbot wants to merge 3 commits into
Open
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- injectAnswerToAgent awaits the transport with a bounded ack window: a rejected message-fallback delivery now throws instead of being logged as injected, and PTY dispatches log confirmed-vs-best-effort honestly - HarnessBrokerTransport merges caller-configured relay.env as the base of the spawned broker environment so embedders without resolveRelayEnv keep their credentials and runtime settings - the defaults-to-legacy test pins RELAYFLOWS_INTEGRATION_TRANSPORT so it cannot depend on the invoking shell Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…ocess exit Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BrokerTransportPortand a published-package-backedHarnessBrokerTransportrunner.tsRELAYFLOWS_INTEGRATION_TRANSPORTValidation
npm ci— exit 0npm run build:primitives— exit 0npm test— exit 0 (61 files, 1,018 tests)npm run typecheck— exit 0CODEX_WORKFLOW_OK,DONE); this was not Native autopilot-tick and exercised 0/9 Native deterministic stepsRunner LOC
packages/core/src/runner.ts: 11,832 → 11,241 lines (−591 in PR-1), progressing toward the ≤7,900 four-PR end-state budget.PR-1 of the signed-off stage-2 sequence only. No merge requested.