fix: guard deterministic repair scope - #46
Open
miyaontherelay wants to merge 5 commits into
Open
Conversation
Session-Id: 01a03a38-b143-7000-84b5-2fc9c9c26f69
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…s in the repair guard Four review findings on the repair-scope guard, each with a regression test: - a planted symlink cycle (ELOOP) now records a violation and restores instead of throwing past the restore path - restoration rebuilds a real parent chain so a parent directory swapped for a symlink cannot redirect the restore to an external target - interpreter eval modes resolve their nested command (bash -c scripts become protected paths) and fail closed when inline code references a local script - custom-step resolution preserves the invoking step's cwd/workdir so repairProtection paths resolve against the gate's actual directory Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- an absent protected path masked by a parent directory replaced with a file is now a violation: snapshots track parent-chain traversability and restore rebuilds the real chain - nested shell parsing models cd (directory state), source/. (protects the sourced script), exec (recurses), and eval (fail closed) - inline eval payloads probe extension-less import/require specifiers against local module layouts (x.py, pkg/__init__.py, pkg/__main__.py, x.js, index.js) - python -m probes pkg/__main__.py as well as pkg.py - custom-step validation no longer warns that supported cwd/workdir fields will be ignored Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
- parent-chain check resolves symlink ancestors: a dangling link or cycle planted over a parent now reads as blocked, not as genuine absence - the shell tokenizer carries separators; cd only threads the effective directory across proven-sequential positions (start, ;, &&, newline) and fails closed behind ||, |, or & - builtins match on the raw token, so a script literally named ./source is protected as a script - sourced files are protected AND inspected recursively (depth-capped, cycle-safe); a cd inside a sourced file marks later resolution unresolved - quoted side-effect imports are scanned; bare-identifier import matching is python-only so JS import bindings stop false-positiving; relative-path specifiers are probed without dotted-module mangling Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
2 issues found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/core/src/runner.ts">
<violation number="1" location="packages/core/src/runner.ts:5242">
P1: When a failing command precedes `cd` with `&&`, the scanner changes `effectiveCwd` even though the shell skips that `cd`, so a later gate can run from the original directory without protection. Treat `&&` as non-sequential for `cd` resolution, or fail closed for the affected command chain.</violation>
<violation number="2" location="packages/core/src/runner.ts:5259">
P1: With four nested sourced scripts, the depth limit records the last script but silently skips inspecting it and its local dependencies. Remove the arbitrary cutoff, relying on `visited` for cycle termination, or mark the plan unresolved when the inspection limit is reached.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
…ully - cd now threads the effective directory only from provably-executed positions (start, ;, newline); behind &&, ||, |, or & it fails closed - sourced-script inspection relies on the visited set alone, so arbitrarily deep source chains are inspected instead of silently cut off at depth 3 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repairProtection.protectedPaths, resolved from the effective gate cwd.finallypath and restore violations before failing the run.Execution paths covered
finallycheck still detects and restores mutations.terminalSuccessExitCodes: existing terminal-success coverage confirms the completed-early result does not spawn repair.A green suite proves the paths that have tests, and nothing else.
Verification
npm run typecheckvitest run --no-file-parallelism --maxWorkers=1 --minWorkers=1 --retry=1(66 files, 1,060 tests)