chore(ci): preserve RelayFlow proof timeout evidence - #1617
Conversation
Session-Id: 01a03d75-2261-7e60-911e-7dd3188d648b
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe PR proof workflow timeout changes from 60 minutes to 45 minutes. Contract coverage verifies the new timeout and rejects the previous value. ChangesPR proof timeout
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The PR separates the workflow and dispatcher timeouts so terminal proof state can be preserved before teardown. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. Full details: Description checkExplanation The description includes the summary, RelayFlow Proof classification, validation results, and operational context. The Test Plan checklist is replaced by a Validation section, but the required testing information is still provided. Screenshots are not applicable. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
khaliqgant
left a comment
There was a problem hiding this comment.
Approving — minimal, correct, and the regression guard is the right shape.
What it does: drops the workflow ceiling from .timeout(3_600_000) to .timeout(2_700_000), giving 15 minutes of headroom under the dispatcher's PR_PROOF_CLOUD_TIMEOUT_MS: 3600000.
Why this matters. The two values were previously identical, so the workflow could never self-terminate before CI cancelled it. On GitHub run 32944656109 / Cloud run f95d160f-9fd6-4f1b-8ef7-a9bac3c21fc6, the dispatcher polled status: running for 59 minutes and then issued Cancelling Cloud RelayFlow run (deadline exceeded). That external cancellation reaped the Daytona sandbox (54fae474-... no longer exists) and left the durable log frozen at 962 bytes, ending at [bootstrap] Started relayfile-mount daemon. Every stall of this class destroyed its own evidence. This change lets Cloud persist terminal step state and retain the sandbox first.
Test coverage. pr-proof-contract.test.ts asserts both the new value and the absence of the old one. The negative assertion is what prevents a silent revert back to the colliding value — a real drift guard, not redundancy.
Margin. 15 minutes is sufficient for terminal-state persistence plus sandbox retention while leaving the dispatcher its own polling budget. No concern.
Disclosure. I orchestrated the agent that authored this, so treat this as informed technical review rather than fully independent review. The change is two lines plus a test, and 36/36 checks are green.
Summary
This changes the proof harness, not Relay runtime behavior. It lets the workflow self-fail and persist terminal step state before the outer dispatcher cancels and reaps its orchestrator sandbox.
RelayFlow Proof
non-functionaln/aValidation
git diff --checkpassedNo production deploy and no merge performed.