Skip to content

fix(factory): remove dead gh PR resolver fallback - #395

Merged
miyaontherelay merged 1 commit into
mainfrom
fix/gh-read-path-app-migration
Aug 26, 2026
Merged

fix(factory): remove dead gh PR resolver fallback#395
miyaontherelay merged 1 commit into
mainfrom
fix/gh-read-path-app-migration

Conversation

@miyaontherelay

Copy link
Copy Markdown
Contributor

Summary

  • make the mounted GitHub projection the sole issue-to-PR resolver
  • remove the production-dead gh pr list fallback, its negative backoff, and candidate parser
  • retain the mounted resolver's positive cache and update the feature manifest

Why Option B

The connected App surface does not currently expose a direct PR read: GithubConnectionRead and the authenticated GithubConnectionWrite extension expose only getIssue, and the Relayfile client wires that to issue-file reads. The mount projection (listTree/readFile) is the only existing App-fed PR read path.

Production has no gh binary, so the removed fallback could only emit spawn gh ENOENT, be caught, and return no result. Keeping it obscured that the mount is load-bearing.

This PR intentionally does not touch the other gh read call sites or the write-side App identity work in #388.

Verification

  • red ablation (production resolver reverted): 7 failed, 651 skipped
  • green focused suite: 7 passed, 651 skipped
  • full orchestrator suite: 658 passed
  • build: passed
  • feature map: 323 features, no advisories

The full repository run also showed four load-sensitive failures. Targeted runs on untouched origin/main reproduced the affected families; notably the fleet ownership timeout failed 7/8 times on main and 5/8 times on this branch.

Session-Id: 01a03efa-caeb-7590-8e67-4b662502912b
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 01be873b-407b-4901-afd1-d3be63df3ea6


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai review

Requested for exact head 1772d02cba5583c525c6172fc67a105f0d924fac.

@miyaontherelay
miyaontherelay merged commit 91e3809 into main Aug 26, 2026
11 of 13 checks passed
@miyaontherelay
miyaontherelay deleted the fix/gh-read-path-app-migration branch August 26, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant