Repository navigation
Revert: let idle desktop chat views beyond the three most recent go - #2473
Merged
Merged
Conversation
…2472)" This reverts commit 2c717c0. Releasing an open view lets another process (the codeaf CLI on the same home) run a turn in a chat the window is showing. Before #2472 that turn was refused ("this conversation is open in another window"). After it, the turn runs, the window gets only working/idle state for it and none of its entries, and the app's next open of that chat starts a spurious "the app closed unexpectedly" resume turn. Restore the held view until a fix keeps both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2472. That change reopened #2471.
Why
#2472 let the idle sweep release an open desktop view once it is outside the 3 most recently used. A regression check found that this lets another process run a turn in a chat the window is still showing. The window then misses that turn's content.
Measured with a standalone
codeaf app(app/v3 2c717c0) on a scratch home, driven over its wire:codeaf chat --once --session <released chat>on the same home ran (exit 0). Before Let idle desktop chat views beyond the three most recent go #2472 the same command is refused with "this conversation is open in another window". The control run against a still-held chat on the same binary refused it in exactly that way.agent.changedworking → idle. It sent noturn.*and noentry.added, andupdated_atdid not move. The CLI process holds no engine host, so the app cannot join it, and the window shows nothing of the turn until it re-reads.turn.done ok:true). On reopening the chat, though, the app then started an extra turn on its own: "The app closed unexpectedly while you were in the middle of answering…".Rather than ship that, this restores the held view until #2471 has a fix that bounds the per-chat files and keeps the refusal. Possible directions:
Change
git revertof 2c717c0, plus a change entry. The code, test and manual return to their state before #2472.🤖 Generated with Claude Code