Repository navigation
App wire: announce collections.factory_job when collections hold Factory jobs - #2468
Merged
AbirAbbas merged 3 commits intoNov 6, 2026
Merged
Conversation
…ory jobs An engine serving collections now also announces collections.factory_job in hello.features. This wire already checks factory_job refs (a Factory job by factory and number) and passes them to every collector, but a client had no way to tell such an engine from an older one that announces only collections and refuses the kind with bad_params. A client can now check the feature before it adds a job, instead of finding out after it made one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd, not must Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An engine that serves collections now also announces
collections.factory_jobinhello.features.This wire already validates
factory_jobrefs (a Factory job byfactoryand job number) and passes them to every collector. An older engine that announces onlycollectionsmay refuse the kind withbad_params, and a client had no way to tell the two apart before it tried. With the flag, a client can check before it adds a job to a collection, instead of creating a Factory job and only then finding that it cannot be grouped.Generic and additive: one new file with the constant and its hello helper, one registration line in the hello assembly, a PROTOCOL.md sentence. No change to any method, ref shape or store.
Validation contract
collections.factory_job:TestCollectionsFactoryJobFeatureFollowsCollections, and the plain-engine half ofTestCollectionsFeatureFollowsTheEngine.collectionsandcollections.factory_job:TestCollectionsFactoryJobFeatureFollowsCollections,TestCollectionsFeatureFollowsTheEngine(its exact feature list gains the new flag).factory_jobref with its factory reaches the collector, and one without a factory is refused withbad_paramsfirst:TestCollectionsFactoryJobFeatureIsServed.A client can gate Factory-job grouping on this flag, so on an engine without it no job is created that cannot then be grouped.
🤖 Generated with Claude Code