Skip to content

App wire: announce collections.factory_job when collections hold Factory jobs - #2468

Merged
AbirAbbas merged 3 commits into
workstreams/mainfrom
workstreams/mmf-collections-factory-job
Nov 6, 2026
Merged

AbirAbbas merged 3 commits into
workstreams/mainfrom
workstreams/mmf-collections-factory-job

Conversation

@AbirAbbas

@AbirAbbas AbirAbbas commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

An engine that serves collections now also announces collections.factory_job in hello.features.

This wire already validates factory_job refs (a Factory job by factory and job number) and passes them to every collector. An older engine that announces only collections may refuse the kind with bad_params, and a client had no way to tell the two apart before it tried. With the flag, a client can check before it adds a job to a collection, instead of creating a Factory job and only then finding that it cannot be grouped.

Generic and additive: one new file with the constant and its hello helper, one registration line in the hello assembly, a PROTOCOL.md sentence. No change to any method, ref shape or store.

Validation contract

  • An engine without collections never announces collections.factory_job: TestCollectionsFactoryJobFeatureFollowsCollections, and the plain-engine half of TestCollectionsFeatureFollowsTheEngine.
  • An engine with collections announces both collections and collections.factory_job: TestCollectionsFactoryJobFeatureFollowsCollections, TestCollectionsFeatureFollowsTheEngine (its exact feature list gains the new flag).
  • The announced feature is served: a factory_job ref with its factory reaches the collector, and one without a factory is refused with bad_params first: TestCollectionsFactoryJobFeatureIsServed.

A client can gate Factory-job grouping on this flag, so on an engine without it no job is created that cannot then be grouped.

🤖 Generated with Claude Code

AbirAbbas and others added 3 commits November 6, 2026 10:48
…ory jobs

An engine serving collections now also announces collections.factory_job
in hello.features. This wire already checks factory_job refs (a Factory job
by factory and number) and passes them to every collector, but a client had
no way to tell such an engine from an older one that announces only
collections and refuses the kind with bad_params. A client can now check the
feature before it adds a job, instead of finding out after it made one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd, not must

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AbirAbbas
AbirAbbas merged commit 43615ed into workstreams/main Nov 6, 2026
6 checks passed
@AbirAbbas
AbirAbbas deleted the workstreams/mmf-collections-factory-job branch November 6, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant