Repository navigation
Settle the setup turn before counting idle chat changes - #2467
Merged
Merged
Conversation
The vague fixture opener can finish its intent naming after the turn ends. Its final title and intent_name records then publish another head inside the idle counting window, before the expected release row. Name the fixture before sending, join its completed capture, and wait for that exact head on the peer before opening the window. Keep the exact change-count and lease assertions unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
TestAppIdleReleaseI1I2BackgroundChatStaysReleasedUntilSend, which sometimes reported "I2 idle chat emitted 2 changes, want 1". Test-only.Cause. The extra change was the setup turn's own naming tail, not an idle chat waking up. After the turn, the second-chance naming writes the chat's title and intent name records, 257 bytes. Their capture and publication can finish after the test has started counting. That publication moves the saved head while the status, holder and fence stay the same. It makes no model calls and adds no spend.
Fix.
Validation:
-count=200: passes, and the idle-count assertion held in all 400 runs at one and four CPUs.-count=20: pass.Separately, the same test's final Send is sometimes refused with "This chat is available to continue here" at four CPUs, on base as well. That's being diagnosed on its own and is not changed here.
🤖 Generated with Claude Code