[AbirAbbas]

Summary

Follow-up to #2446. With CODEAF_TASK_BELT=node (the older session-tree road, still a live escape hatch), tasks had depth 3, 20 children per node and a per-node bill limit, but no duplicate-title refusal and no spend total for the tree. This gives that road the same bounds #2446 gave the default road, reusing its code.

• Duplicate work is refused tree-wide. At the one admission door every older-road child passes (claimChild: proposals, quick tasks, divisions, plan dispatch), a title equal to any non-cancelled task in the same tree after plandb's normalization is refused with Tasks: a worker does its own task, and a task tree is bounded in depth, count and spend #2446's words, and nothing starts. A division that names the same work twice is refused whole. Pending proposals reserve their titles. plandb.NormalizedTitle exports the existing normalization so both roads share one definition. A typed task starts its own tree, so separate trees may reuse a title.
• A tree spend total. The older road already refuses a worker's next request when its own node's bill reaches the per-node limit. Beside that check, the tree's summed bill (the root and every descendant node, each node's own bill, which includes its workers', repairs', checker's and paid tool receipts) is compared with the tree's ceiling. The ceiling is fixed when the root is admitted, using Tasks: a worker does its own task, and a task tree is bounded in depth, count and spend #2446's arithmetic (the lower of crew.task_cap, $5 by default, and the conversation's remaining limit, factored into taskTreeCost), and kept in the checkpoint as an additive fact, so a restore cannot re-grant it. A node over it ends on the cost-limit ending with the configured-limit words, or the conversation-limit words when that limit bound it. A node in flight ends at its next request, as with the per-node limit; a node that starts later spends nothing. No new guard, stop or cancellation path.
• The default road is unchanged: the new title gate and tally are off there.

Validation contract → tests (internal/session/task_node_bounds_test.go)

Contract	Test
C1 duplicates anywhere in the tree refused; cancelled titles reusable; different titles still start	TestNodeTreeRefusesDuplicateWorkAnywhere, TestNodeTreeAllowsCancelledTitlesAndSeparateRoots, TestNodeTreeReservesPendingProposalTitles
C2 a batch naming the same work twice is refused whole	TestNodeTreeRefusesAnEntireDuplicateDivisionAndQuickTask
C3 separate trees may share a title and keep their own totals	TestNodeTreeAllowsCancelledTitlesAndSeparateRoots, TestNodeTreeSpendStopsEveryNodeAndNamesTheBindingLimit
C4 the tree total stops every node of the tree and names the binding limit; restores keep the ceiling	TestNodeTreeSpendStopsEveryNodeAndNamesTheBindingLimit, TestNodeTreeCheckpointKeepsTheUnspentAllowance, TestNodeTreeCheckpointWithoutLimitComputesItAtRestore, TestNodeTreeWithNoConversationAllowanceSpendsNothing, TestNodeTreeLimitRefusesBeforeCheckpointWrites
C5 a node under the ceiling finishes as before	TestNodeTreeUnderTheCeilingFinishesNormally
C6 one normalization for both roads	TestNodeTreeUsesThePlanStoresWorkIdentity

Existing tests changed

All three used repeated titles as filler, which C1/C2 now refuse on purpose. Their fixtures name distinct work; every assertion is unchanged.

• TestADivisionWiderThanTheCapIsRefusedWholeRatherThanHalfTaken: fills the fan cap with 18 distinct parts instead of repeating two titles, and asserts that setup count.
• TestAThirdAskAfterARepairNeitherRefusesNorDoublesTheFamilysChecks: the third ask names ranking/browsing instead of re-sending rank/browse.
• TestAPartsBriefHoldsItsBoundWhateverLengthTheFieldsArriveAt ("every field at once"): its two parts had the same full-length title; the second now starts "the beta adapter " and every field stays at full length.

Review round

A fresh review of the first version found five majors, all in its separate shared spend guard (a limit stop read as a person's stop, paid tool receipts missed, a restore could re-grant a conversation-bound allowance, cancellation waited on checkpoint writes, a racing test). The tree total was redone as the check above, which has none of those paths.

🤖 Generated with Claude Code