Repository navigation
fix: avoid ?. over pointer member (CS8978 on .NET 10 SDK) - #21
Merged
Merged
Conversation
port?.PortData needs a newer compiler than the .NET 10 SDK ships (CS8978, 'void*' cannot be made nullable). Equivalent ternary compiles on both SDK 10 and 11.
Agash
added a commit
that referenced
this pull request
Oct 13, 2026
Distribution-built .NET SDKs are the 1xx band; the other legs compile both targets with the .NET 11 compiler, which missed CS8978 (#21).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PipeWireFilter.UpdatePropertiesdoesn't compile on the .NET 10 SDK:port?.PortData(conditional access over avoid*member) needs the Roslyn that ships with the .NET 11 SDK. Reproduced on 10.0.112 with LangVersion 12/13/14, so no flag works around it. CI stays green only because it builds with the 11 RC SDK.This swaps in the equivalent ternary, which builds on both SDKs. It's the only such spot in
src/, behavior is unchanged.