Fix: skip YouTube talk links in link check - #58
Merged
Conversation
The two talk recordings on /research (Fluid, MLSys'21, from source/_data/peifeng.bib) intermittently come back as `HTTP 302 => 429` from GitHub Actions — YouTube rate-limits datacenter IP ranges. Both return 200 over a normal connection. These were the two remaining errors that failed the link check on the 24b2588 merge. 429 is an HTTP status rather than a connection failure, so `--connection-failures-as-warnings` deliberately does not cover it — that flag is meant to keep real HTTP errors fatal. Rate limiting is the one case where the host is telling us the link is fine and to go away, which is the same situation as the existing github.com/Aetf entry. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #57. That PR demoted connection failures to warnings, which cut the noise (94 warnings → 70) but deliberately left real HTTP errors fatal. Two of those remained, and they're what actually failed the link check on the #57 merge commit itself:
Those are the two talk recordings on
/research(Fluid, MLSys'21, fromsource/_data/peifeng.bib). YouTube rate-limits datacenter IP ranges; both return 200 over a normal connection — verified.429 is an HTTP status, not a connection failure, so
--connection-failures-as-warningscorrectly doesn't cover it. But rate limiting is the one case where the host is explicitly saying "the link is fine, go away", which is exactly the situation the existinghttps://github.com/Aetfentry ("github.com too many request") already covers. So it goes in the skip file with a comment, per the file's own convention.Note the next merge to develop happened to pass, so this is intermittent rather than constant — which is precisely why it's worth pinning down now instead of leaving it to re-break a future automerge.
🤖 Generated with Claude Code