Repository navigation
[AGM-3116] Improved instructions for granting browser folder permissions - #938
Merged
anastasiia-fedotova merged 12 commits intoOct 9, 2026
Merged
Conversation
|
Preview was deployed to: https://pull-request-938.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-938.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-938.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-938.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-938.kb-adg.pages.dev/ |
el-termikael
reviewed
Oct 2, 2026
kpokas-adguard
approved these changes
Oct 2, 2026
…27.md Co-authored-by: Elena Ter-Mikaelyan <e.ter-mikaelyan@adguard.com>
…27.md Co-authored-by: Elena Ter-Mikaelyan <e.ter-mikaelyan@adguard.com>
…27.md Co-authored-by: Elena Ter-Mikaelyan <e.ter-mikaelyan@adguard.com>
|
Preview was deployed to: https://pull-request-938.kb-adg.pages.dev/ |
2 similar comments
|
Preview was deployed to: https://pull-request-938.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-938.kb-adg.pages.dev/ |
el-termikael
approved these changes
Oct 5, 2026
neshumov
requested changes
Oct 5, 2026
neshumov
left a comment
neshumov
left a comment
Contributor
There was a problem hiding this comment.
I checked the article against the current AdGuard for Mac master (060ae7f9a, AG-59489 "Change UX in Browser Folder Access"). The UI strings and navigation paths match the code, but a few statements are inaccurate or incomplete.
Needs fixing
- The "Allow Access…" button only covers the default browser. Both Preferences → Assistant and the Setup Assistant check only the system default browser. The article says the steps work "regardless of which browser is used". If the affected browser is not the default one, AdGuard shows no button, and the user has to open System Settings → Privacy & Security → Files & Folders manually. Please say this explicitly.
- The main-window notice is not always shown. "Allow access to your browser folder for the Assistant" appears only on macOS 27+, only if the Assistant was installed at least once, and only while access is denied for the default browser. It disappears permanently after the first click. Please add a hint such as "If you don't see this notice, use Preferences → Assistant".
- Option A covers only Chrome. Besides Opera, Comet and The Browser (Arc) also write their manifest to
Google/Chrome/NativeMessagingHosts. Gecko browsers Zen, Floorp and LibreWolf shareMozilla/NativeMessagingHosts, so they depend on Firefox being installed. The article now claims Gecko support but gives no guidance for this case. - The Full Disk Access caution contradicts Option B. "Full Disk Access is not required for AdGuard to work properly" sits in the section that offers it as a fix. Suggested wording: "not required in general; use it only as a workaround for Browser Assistant".
Typos and consistency
- Caution block: "You should only enable it only if…" has a duplicated "only".
- Image alt text
AdGuard popup *mobilehas a stray asterisk. - The article uses "Allow Access..." (three dots) while the app uses "Allow Access…" (ellipsis character).
Please double-check (cannot be verified from code)
- "at the bottom" for the main-window notice and "top-right corner" for the gear icon; compare with the screenshots.
- That macOS 27 requires Chrome to be installed before it allows requesting access to its folder.
|
Preview was deployed to: https://pull-request-938.kb-adg.pages.dev/ |
neshumov
approved these changes
Oct 6, 2026
|
Preview was deployed to: https://pull-request-938.kb-adg.pages.dev/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can be merged after beta 2 is out (planned at the beginning of the next week)