docs(plan): correct §2.2 classid gen-marker to high-u16 (post-#611 follow-up)#612
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9fd586fd7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | OSINT | `0x0007` | **`0x1007`** | `0x07` OSINT | canon ✓, kept as-is | | ||
| | FMA | `0x0008` | **`0x1008`** | `0x08` OCR | **kept as-is** (jungle-avoidant). Canon home is `0x0A` Anatomy — firewall-split from `0x09` Health PHI (lib.rs:1078-1086) — so the realign to `0x100A` is **deferred domain-debt**; flip this one row if/when realigned. | | ||
| | CPIC | `0x000C → 0x000D` | **`0x100D`** | `0x0D` Genetics (new) | the **one forced move**: `0x0C` is Automation (HIRO/MARS), so CPIC's current `0x0C` collides — Genetics mints into the next free slot, then gen-marks. | | ||
| | OSINT | `0x0000_0700` | **`0x1000_0700`** | `0x0700` → Osint ✓ | **wired (#612)** — test asserts the route | |
There was a problem hiding this comment.
In the reviewed tree, ReadMode still has only value_schema and edge_codec (crates/lance-graph-contract/src/canonical_node.rs:815-819) and BUILTIN_READ_MODES registers only NodeGuid::CLASSID_OSINT (0x0000_0700) at canonical_node.rs:891-899; rg 0x1000_0700 finds only this plan text. Marking the V3 OSINT classid as “wired” and saying a test asserts it can cause Phase 1 to be treated as complete even though the high-u16 route currently falls through to ReadMode::DEFAULT; please downgrade this status to planned/deferred or add the actual #612 wiring in the same tree.
Useful? React with 👍 / 👎.
Codex P1 — §2.2 corrected to the high-u16 generation-marker scheme. The classid u32 is [custom hi : canon lo] and classid_concept_domain routes on the LOW u16, so the marker goes in the HIGH (custom) half, preserving the canon 0xDDCC low u16: OSINT 0x0000_0700 -> 0x1000_0700 (wired in #612). The earlier 0x1007 low-half form is rejected (0x1007 as u16 >> 8 = 0x10 -> Unassigned). FMA is 0x0A01 (Anatomy, already realigned); Genetics domain TBD (0x0D is HR in the contract). CodeRabbit major — §2.1: mark ReadMode.tail_variant as the P-A (#612) addition, not a pre-existing field (the live struct has only value_schema + edge_codec). CodeRabbit minor — replace every 0x1007 reference (§2 Phase-1, §2.1 L3, INTEGRATION_PLANS) with the high-u16 scheme; split V1/V2 in the board note (legacy zero-prefix keeps its current tail — V1 default or V2 new_v2-minted). Deferred to the harvest's owning session (commit 4a2f9ba): the missing-Qualia + net-tally consistency fixes and the EPIPHANIES MD038 lint. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TzqvDqbFRzyx17EkLKBoZF
AdaWorldAPI
force-pushed
the
claude/v2-doc-classid-fix
branch
from
f9fd586 to
6f0cdf7
Compare
|
Warning Review limit reached
More reviews will be available in 6 minutes and 23 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
What
Post-merge follow-up to #611. PR #611 merged the v2 migration plan with the Codex-P1 §2.2 error still present —
origin/mainroutes OSINT through0x1007, which corrupts the OGAR domain byte (0x1007 as u16 >> 8 = 0x10→ Unassigned). The correction was authored during #611's review but did not ride along into the merge. This lands it.The fix
The classid u32 is
[ custom (hi u16) : canon (lo u16) ], andclassid_concept_domainroutes on the low u16 (the OGAR0xDDCCcodebook). So the generation marker goes in the high (custom) u16, leaving the canon low u16 untouched — "replace the first0with1" on the full u32:0x0000_0700 → 0x1000_0700(domain route0x0700→ Osint ✓)A low-half form like the earlier
0x1007overwrites the domain byte and is rejected (retained in the doc as the explained negative example).Changes
§2.2rewritten to the[custom:canon]framing + the corrected OSINT table.0x1007stragglers in§5(the watch) and§6(sequencing table) that the original review commit left behind — the only surviving0x1007is now the line explaining why it is rejected.INTEGRATION_PLANS.mdentry corrected to match (V1/V2 split + high-u16 scheme).Doc-only; no code paths touched.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TzqvDqbFRzyx17EkLKBoZF
Generated by Claude Code