Repository navigation
mask-risc: name ndarray by its canonical git coordinate so Quack is consumable by git - #1457
Conversation
… it to the sibling The relative path ../../../ndarray leaves the checkout, so a git consumer of lance-graph-quack (which depends on mask-risc) could not resolve ndarray at all. That is CARGO-COMPUTE-SUBSTRATE rule 5. The root [patch."https://github.com/AdaWorldAPI/ndarray"] points the coordinate back at ../ndarray, so this workspace keeps one ndarray identity and no network for it (cargo tree -d unchanged from main). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 16 minutes. View limit details
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
…e too r2il-mask-abi-probe, glove-parity, sap, d-diamond-1-probe and dir-sim are their own workspace roots, so the root [patch] does not reach them. Without the same patch they would fetch ndarray by git, and d-diamond-1-probe (which path-deps ndarray directly) would carry two ndarray identities. cargo tree -i ndarray now shows the one sibling checkout in each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
2 participants
Problem
lance-graph-mask-riscdeclaredndarray = { path = "../../../ndarray" }. That path leaves the lance-graph checkout, so any crate that consumeslance-graph-quack(which depends on mask-risc) by git fails to resolve:This was measured from HubSPO-rs, which needs Quack for its filter compiler (D-QRY-1, AdaWorldAPI/HubSPO-rs#19). The relative path also breaks rule 5 of
.claude/knowledge/CARGO-COMPUTE-SUBSTRATE.md: relative cross-repo ndarray paths are forbidden.Change
crates/lance-graph-mask-risc/Cargo.toml:ndarray = { git = "https://github.com/AdaWorldAPI/ndarray", branch = "master", default-features = false, features = ["std"] }.Cargo.tomladds[patch."https://github.com/AdaWorldAPI/ndarray"] ndarray = { path = "../ndarray" }. This is the target geometry in §3 of the same doc: this workspace keeps building against the sibling checkout and needs no network for ndarray.r2il-mask-abi-probe,lance-graph-glove-parity,lance-graph-sap,d-diamond-1-probeandlance-graph-dir-sim. Each is its own workspace root, so the root[patch]does not reach them. Without it they would fetch ndarray by git, andd-diamond-1-probe, which also path-deps ndarray directly, would end up with two copies.Only mask-risc moves. The other crates that use a path dependency on ndarray do not block a git consumer of Quack and stay as they are.
Verified
cargo test -p lance-graph-mask-risc -p lance-graph-quack -p lance-graph-cypher-quack: all green, 0 failures.cargo tree -d -e normal | grep ^ndarrayin the root: same output asmain. It lists the0.17.2sibling and the0.16.1that lance already pulls in from crates.io; this PR adds no third copy.cargo tree -i ndarrayin each of the five standalone workspaces shows exactly one ndarray, the sibling checkout, with no unused-patch warning.dir-simandglove-parityCargo.toml in their dependency sections; this PR only appends a new section at the end of those files. Lab v1 (Thompson + context arms on Gomoku); phasor_trig_probe on PhaseLut #1456 does not touch any manifest.🤖 Generated with Claude Code
https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z