Repository navigation
probe(recipe): order statistics on the shipped PhaseLut, all-ranks timing, power-sum fold cost (D-ART-2) - #1421
Merged
Conversation
…er-statistics timing; shipped checked_affine cross-check Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
…old cost by ingredient) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
The D path needs a 2-D window operand that mask-risc's IR lacks. Shipping F alone would bring back the 2.5x worst case the per-query choice removes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
AdaWorldAPI
marked this pull request as ready for review
October 8, 2026 22:45
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to D-ART-1 (#1418). It covers three open items and changes only the probe and the board.
1. Sector permutation on
ndarray::simd::PhaseLutArm E (two fixed orderings plus one cosine) now also runs with every cosine taken from the shipped table (ndarray #343).
For comparison:
f64sector arm costs 42–56 ns.The bound
(r + e) · lerp_error_bound()is asserted on every rank. As a disable run, usingnearestinstead oflerpgives 0.077 and fails it.2. All m order statistics per instance
The interpolated profile row wins here: 18 / 42 / 493 ns for m = 3 / 16 / 256. Against it:
PhaseLut3. Where the power-sum fold spends its time
The earlier "fused 3.7 vs shipped 4.8 ns/row" gap was noise between two
i128folds. Isolated by ingredient on 1M rows:i128accumulatorsi64accumulatorsThe mask walk and group key add nothing measurable. The lever is the accumulator width.
i64is not exact for full-rangei32, so the proposal is a split-accumulator fold in ndarray: PROBE.The probe's
i128summary transform also agrees bitwise with the shippedCrossPowerSums::checked_affine(ndarray #344).Board:
entries/2026-10-08-recipe-probe-phaselut-foldcost.md, plus aSTATUS_BOARD.mdrow D-ART-2.🤖 Generated with Claude Code
https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Generated by Claude Code