Repository navigation
Board: D-STO-5 shipped; shared pattern doc; record the racing-writer gap - #26
Merged
Merged
Conversation
…n doc Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Lance rebases an Append, so a writer racing past the pre-append check lands a durable batch; the post-append check only detects it. One writer comes from ownership. ISS-LOG-RACING-WRITER records the gap and the F6 fix shape (in-band (cycle, batch_hash) reconciliation). Doc comments only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
AdaWorldAPI
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Board hygiene and doc comments; no behaviour change.
STATUS_BOARD.md: D-STO-5 moves to Shipped (D-STO-5: history as a fold over resident log records (0.72 ms, was 336 ms) #25).LATEST_STATE.md, plan §5.2 and the D-STO-5 row now point to lance-graph.claude/knowledge/split-tunnel-sparse-append-resident-fold.md(lance-graph #1466). That doc records the pattern D-STO-1 (persistence half): one Lance version per batch, rebuilt by replay #23–D-STO-5: history as a fold over resident log records (0.72 ms, was 336 ms) #25 built here, and this crate is its reference implementation.ISS-LOG-RACING-WRITER, found by review on lance-graph #1466:commit's version checks.Append(lance-graphspog-alpha-channel-v1.mdF6). The check after the append only detects it, and replay then refuses the log.(cycle, batch_hash)reconciliation or a writer lease. It isn't needed while one owner writes each log.log.rsdoc comments are corrected to say the checks detect a racing writer and do not prevent one.cargo fmt --checkpasses. Only comments changed inlog.rs.🤖 Generated with Claude Code
https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z