Repository navigation
D-QRY-3 (board half): count and amount per pipeline stage as two grouped programs - #21
Merged
Merged
Conversation
…rograms Board::count_query / amount_query lower to GroupReduce over the composite address pipeline × stages + stage; columns() normalises both sinks so a stage whose records all lack an amount reads None, not 0. weighted() is exact in minor units × basis points. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
AdaWorldAPI
pushed a commit
that referenced
this pull request
Oct 10, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hubspo-query::board::Boardimplements HubSpot's pipeline board. For each (pipeline, stage) it gives the record count and the amount sum over the records a view's filter keeps.GroupReduceprograms over the composite addresspipeline × stages + stage(GroupAddr::Pair). No row ids are materialised and no composite key lane is built.amount: None, never0;columns()runs both result buffers throughnormalize_group_sinkto make that distinction.weighted(amount, probability_bp)is exact: the product is kept in minor units × basis points (i128). Weighting a stage's total therefore equals summing the per-record weighted amounts to the last unit; rounding is left to the display.The saved-view half of D-QRY-3 is still open: view definitions as data, and sorting. Quack has no
ORDER BY(rows come back in storage order), so a table view sorted by a property needs its own decision.Evidence
tests/board_oracle.rschecks unfiltered, filtered and narrow boards against a plain per-cell tally. The data is 6,000 deals across 3 pipelines × 7 stages: 4 % are deleted, 25 % have no amount, and one stage has no amounts at all.Disable runs, each with an asserted patch anchor:
The last disable stayed green on the first run, because every fixture occupied all 21 stages. I added a narrow-board test, whose own check requires that fewer than half the stages are occupied; with that test in place the disable goes red.
Workspace fmt, clippy (
--all-targets --no-deps -D warnings) and tests pass locally. Rebased onmainafter #20; no other HubSPO-rs PR is open.🤖 Generated with Claude Code
https://claude.ai/code/session_01PPcakjk7ioQsnasmNDtc5z
Generated by Claude Code