Repository navigation
Bake leaf scales into generated GLB geometry safely - #161
Merged
Merged
Conversation
A non-uniform node scale distorted normals in the renderer, which gave a clouds model made from squashed spheres black patches in the Flappy3D trial. GLBWriter now applies the scale of parts without children to vertices and normals (inverse transpose), leaving the node unscaled. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Match C enum raw values against Int32 results with an explicit conversion (navigation), parenthesize a matrix-vector product the type checker resolved as matrix-matrix, and remove a doubled L10n.text call in the Studio inspector. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
SpectralDragon
changed the title
SpectralDragon
marked this pull request as ready for review
October 17, 2026 16:54
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Non-uniformly scaled procedural leaf parts, such as squashed spheres used for clouds, can shade incorrectly when their scale stays on the node. Bake positive, finite leaf scales into mesh positions and inverse-scale-normalized normals during GLB export. Keep parent transforms and leaf scales with negative, zero, or nonfinite components unchanged, preserving mirrored geometry and avoiding division by zero.
Add regression coverage for preserved transforms, geometry and triangle indices through GLB export/import. Retain the navigation demo's explicit matrix-vector grouping and document procedural scale behavior.
Merge current
mainand resolve both navigation conflicts using its existingInt64C-enum comparisons. The inspector localization fix is already present inmain.Validation
AssetsManager.restrictedResourceRoot = nil; external resource loading is outside these tests.ProceduralModelTestspassed, including 11 unsupported-scale cases and 6 GLB round-trip cases.NavigationTests.swift:42slope assertion failed:abs(start.y - 0.5) = 0.2247191, expected< 0.2. Navigation sources, tests, native dependencies and Math matchmainexactly.git diff --checkpassed. Full engine/editor builds, the AdaScript generator suite and GPU rendering were not re-run for this revision.