Skip to content

Branches - Macaria #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdove92 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Branches - Macaria #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions lib/practice_exercises.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,26 @@

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n^2)

@CheezItMan CheezItMan Sep 18, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct!

# Space Complexity: O(1)
def remove_duplicates(list)
raise NotImplementedError, "Not implemented yet"
i = 1
list.each do |character|
if character == list[i]
list.delete_at(i)
end
i += 1
end
return list
end

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n^2)
# Space Complexity: 0(1)
def longest_prefix(strings)
raise NotImplementedError, "Not implemented yet"
max_prefix = strings.min

@CheezItMan CheezItMan Sep 18, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use min_by so you can get the smallest by length.

max_length = max_prefix.length
strings.each do |string|
while string[0..max_length - 1] != max_prefix[0..max_length - 1]
max_length -= 1
end
end
prefix = max_prefix[0..max_length - 1]
end