fix(queries): don't split on semicolons inside string literals

[TimeToBuildBob]

Root cause

querystr_to_array() naively splits on all ; characters. Category rules get embedded as JSON string literals inside the query — for example a rule with regex foo;bar becomes:

events = categorize(events, [["Work", {"type": "regex", "regex": "foo;bar"}]]);

A plain .split(';') shreds this into two broken fragments before the query reaches aw-server, causing a parse error. Both aw-server-python and aw-server-rust handle ; inside quoted string literals correctly — the bug is entirely in the client-side splitter.

This explains the forum report in #724 and why the UI warning (PR #724) was only a workaround.

Fix

src/queries.ts

The new querystr_to_array tracks double-quoted string context (with backslash-escape support) and only treats ; as a statement separator when it appears outside a string literal.

Also exports querystr_to_array for direct unit testing and adds 4 tests:

• basic multi-statement split
• semicolon inside string literal (the regression case)
• escaped double-quote inside string
• whitespace/empty statement filtering

View files (7 updated)

All view-level query splitting paths now use querystr_to_array instead of a naive .split(';'):

• views/Alerts.vue, views/Search.vue, views/Graph.vue, views/Report.vue, views/QueryExplorer.vue — replace .split(';').map(s => s.trim() + ';')
• views/Timeline.vue, views/Trends.vue — replace the longer split/trim/filter/map chain

Investigation notes (from #724 comment thread)

Checked aw-server-rust's lexer (aw-query/src/lexer.rs): the string-literal rule "([^\"]|(\\\"))*" is matched before the bare ; → Token::Semi rule, so semicolons inside quoted strings are correctly captured as part of Token::String. The server is not the problem.

Fixes #724.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.63%. Comparing base (58173d8) to head (96d2096).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
+ Coverage   38.11%   38.63%   +0.51%     
==========================================
  Files          42       42              
  Lines        2259     2278      +19     
  Branches      428      435       +7     
==========================================
+ Hits          861      880      +19     
  Misses       1377     1377              
  Partials       21       21              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[greptile-apps]

Greptile Summary

The PR introduces quote-aware AQL statement splitting and routes all previously identified view-level query paths through the shared helper.

• Preserves semicolons inside double-quoted literals, including escaped quotes.
• Updates Alerts, Graph, Query Explorer, Report, Search, Timeline, and Trends to pass the helper output directly to the query client.
• Adds focused regression coverage for splitting, quoted semicolons, escapes, whitespace, and empty statements.

Confidence Score: 5/5

The query-splitting fix appears safe to merge.

No blocking failure remains in the previously reported view-level query-splitting paths.

Important Files Changed

Filename	Overview
src/queries.ts	Adds the shared quote-aware AQL statement splitter and regression coverage confirms the reported literal-semicolon case.
src/views/QueryExplorer.vue	Replaces raw-query semicolon splitting with the shared helper before direct query execution.
src/views/Search.vue	Routes generated search queries through the shared statement splitter.
src/views/Timeline.vue	Uses the shared splitter for the newly added AFK-filter query path.
src/views/Trends.vue	Uses the shared splitter for generated category trend queries.
src/views/Report.vue	Routes report queries through the shared splitter.
src/views/Graph.vue	Routes graph queries through the shared splitter.
src/views/Alerts.vue	Routes alert queries through the shared splitter.

_{Reviews (2): Last reviewed commit: "fix(views): use querystr_to_array in all..." | Re-trigger Greptile}

[TimeToBuildBob]

CI flags two lint warnings (treated as errors with --max-warnings=0):

1. src/queries.ts:12 — no-shadow: the inner escape variable shadows the global escape. Renaming it (e.g. isEscaped) will fix this.
2. test/unit/queries.test.node.ts:246 — prettier: trailing newline. npx prettier --write test/unit/queries.test.node.ts should clear it.

Greptile also flagged a P1 (confidence 3/5): view-level query execution paths apparently still call split(';') directly rather than going through the new querystr_to_array. So the regression case (category regex with semicolons) would still fire for those paths. That looks like a real gap worth addressing before merge.

[TimeToBuildBob]

Both issues are now fixed and pushed.

Lint (now passing):

• Renamed escape → inEscape in queries.ts to avoid shadowing the JS global
• Collapsed the two-line string assignment in the test to satisfy prettier

View-level scope (Greptile P1 addressed):
Extended querystr_to_array to all seven views that were still doing a naive .split(';'):

• Alerts.vue, Search.vue, Graph.vue, Report.vue, QueryExplorer.vue — replaced query.split(';').map(s => s.trim() + ';')
• Timeline.vue, Trends.vue — replaced the longer 4-step split/trim/filter/map chain

CI is running on the updated branch.

[TimeToBuildBob]

@greptileai review

[TimeToBuildBob]

CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click.

This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted.