Repository navigation
test(windows): run history-recovery rows 1-3 against the real aw-server.exe in disposable profiles - #864
Conversation
…ide the disposable profile Git-Session-Id: cb91a81d-4907-4dcd-b714-b06dc5ba433b
…row 1 Git-Session-Id: cb91a81d-4907-4dcd-b714-b06dc5ba433b
…t idle time Git-Session-Id: cb91a81d-4907-4dcd-b714-b06dc5ba433b
Row 2: stale Local history plus a saved testing-profile database, newer Roaming. Row 3: Roaming history plus a Python aw-server database that v0.14.0 never imported. Each row runs in its own disposable user. Git-Session-Id: 2872730e-4cc6-4483-9baf-13e1eb338835
…out testing root exists Git-Session-Id: 2872730e-4cc6-4483-9baf-13e1eb338835
Review guide (auto-posted)Structured warm-up for reviewers — what changed, what to run, where to look. Key files
Suggested verification
Known risks / watch points
Suggested review focus
Generated by |
[Low impact] The PR appears safe to merge; no new actionable issues were found. SummaryThis PR tests three Windows history-recovery cases with the real server in separate disposable user profiles.
Reviews (3) · Last reviewed commit: "fix(test): retry transient sentinel read..." · Reviewed by Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
===========================================
+ Coverage 70.81% 86.00% +15.18%
===========================================
Files 51 90 +39
Lines 2916 13089 +10173
===========================================
+ Hits 2065 11257 +9192
- Misses 851 1832 +981 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Git-Session-Id: 02610e12-7f80-5e66-9bc0-b0f7a5f57b79
|
Addressed all four findings in 01d631e:
Added a hermetic PowerShell regression script to the existing Windows guard step. Both guard scripts pass locally under PowerShell, all PowerShell scripts parse, and pre-commit passes. The new regressions exercise delayed/never-ready HTTP, leaked timeout processes, nonzero/missing recovery summaries, and removal of either original backup. Native Windows execution of this new head still needs CI; the previous head's Windows run was green. |
This comment has been minimized.
This comment has been minimized.
🤖 AI code reviewSafe to merge — no P0/P1 findings on latest reviewUpdated after inline dispositions on finding threads — this is the current state; the verdict below is frozen at review time and is kept as the historical record of that pass. Finding disposition
Adds Windows recovery-matrix scenarios that run the real aw-server.exe under disposable user profiles, with new guard tests for HTTP readiness, process cleanup, sentinel polling, and no-recovery-work assertions. Introduces a common helper library, three row-specific scenario scripts, and updates the CI workflow to run them and upload per-row evidence. Needs a look — P2 onlyConfidence 4/5 1 finding ·
|
| commit | score | findings | engine | when |
|---|---|---|---|---|
01d631e254e7 |
4/5 | 7 | llm | 2026-11-17 14:46 UTC |
15c917ad8d2e |
4/5 | 5 | llm | 2026-11-17 15:49 UTC |
15c917ad8d2e |
4/5 | 2 | llm | 2026-11-17 16:35 UTC |
Reviewed 4a45b323a632 · openrouter/deepseek/deepseek-v4-flash-0731 · llm engine · 156s · about this reviewer
Maintainer commands
@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.
…bucket Wait-ScenarioSentinels aborted on the first failed read (e.g. a 404 before recovery or import creates the bucket). Retry until the deadline and rethrow only if the final read still failed. Row 1's first start now uses the shared waiter instead of its own unguarded loop. Adds a hermetic guard regression. Git-Session-Id: d06b680b-a659-52fd-828b-6c9cda29909f
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
|
@greptileai review |
Git-Session-Id: 9dc14d5c-2227-487a-aae7-971ed70df4d5
Follow-up to #859 and #860, which proved that CI can start the real
aw-server.exeas a disposable Windows user whose Known Folder roots (%LOCALAPPDATA%,%APPDATA%) are isolated from the runner profile. This uses that seam to execute the history-recovery rows from #813 through actual Windows root discovery, not explicit helper paths.Each row gets its own disposable user (
awrow1..3), so rows cannot see one another's databases, and a failed row does not hide the others (!cancelled()):*.migrated-*,*.pre-migration-*). SentinelsLOCAL-1..3andROAM-1..3each appear exactly once. A fresh-process restart inserts 0 events.--profile testingprocesses serve exactlyTEST-1..3, recovered from the preserved pre-migration tree, and the second inserts and skips 0.ROAM-1..3andPY-1..3. A restart repeats neither the import nor any event, and the originals are kept.Fixtures are created by the real server, never hand-written SQL, so they track the datastore schema. Sources use colliding event IDs. Rust fixtures are killed with
taskkill /Fafter a committing request, so the asserted events exist only in a non-emptysqlite.db-wal.--dbpathis used only for fixture creation; every assertion run is a default-profile (or--profile testing) start that resolves its roots natively. Per-row evidence JSON is uploaded as thewindows-disposable-profile-evidenceartifact.Not tested: power-loss or pre-import interruption (no production crash knob was added), WAL-only Python events (the Python fixture is a rollback-journal file written with the runner's
sqlite3), and packaged standalone/Tauri artifacts. A CI debug executable is not release acceptance.Pre-flight: the same five commits passed
windows-lateston the fork (run 43282549608, on master1bde448). They are now rebased cleanly onto current master63ed6b3, whose PE-version-resource change also touchesbuild.yml. Test scripts and the workflow only; no production code changes.