Skip to content

Update regressions for corrected at-work origin TAZ - #46

Merged
jpn-- merged 1 commit into
ActivitySim:mainfrom
driftlesslabs:agent/sandag-origin-taz-regressions
Aug 19, 2026
Merged

Update regressions for corrected at-work origin TAZ#46
jpn-- merged 1 commit into
ActivitySim:mainfrom
driftlesslabs:agent/sandag-origin-taz-regressions

Conversation

@jpn--

@jpn-- jpn-- commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary

  • update the SANDAG lockfile from ActivitySim 279e4f9a to e23bb128
  • refresh final_tours.csv for the corrected at-work subtour destination logsums
  • refresh the four affected tour checkpoints in both the legacy and Sharrow reference pipelines
  • retain all unaffected checkpoint files byte-for-byte to avoid Parquet encoding and timestamp churn

Root cause

ActivitySim PR #1094 corrected two-zone destination presampling so the configured origin MAZ is always mapped to its TAZ. For SANDAG at-work subtours, that means using the workplace TAZ instead of a stale home TAZ when computing destination logsums.

The model choices did not change, but 17 at-work destination_logsum values did. One of 229 tours exceeded the final CSV comparison tolerance, causing both variants of the ActivitySim main-branch SANDAG job to fail. This PR updates the expected outputs rather than reverting the corrected mapping or weakening tolerances.

Addresses ActivitySim/activitysim#1099.

Impact

No SANDAG model code, configuration, origins, destinations, or choices change. The regression data now records the corrected origin-TAZ logsums for legacy and Sharrow execution.

Validation

  • uv lock --check
  • uv run --locked pytest test/test_sandag_abm3.py -q2 passed
  • git diff --check
  • semantic CSV comparison confirmed that only destination_logsum changed, on 17 at-work tours
  • semantic pipeline comparison retained only the four affected tour checkpoints in each execution mode

@jpn--
jpn-- marked this pull request as ready for review August 19, 2026 15:27
@jpn--
jpn-- requested a balanced review from Copilot August 19, 2026 15:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates SANDAG regression baselines for ActivitySim’s corrected at-work subtour origin-TAZ mapping.

Changes:

  • Advances the locked ActivitySim revision.
  • Updates 17 affected tour destination logsums.
  • Refreshes four affected checkpoints for legacy and Sharrow pipelines.

Reviewed changes

Copilot reviewed 1 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
uv.lock Advances ActivitySim to e23bb128.
test/regress/final_tours.csv Updates affected at-work destination logsums.
test/regress/reference-pipeline-hh100-recode.parquetpipeline/tours/atwork_subtour_destination.parquet Refreshes Sharrow destination checkpoint.
test/regress/reference-pipeline-hh100-recode.parquetpipeline/tours/atwork_subtour_mode_choice.parquet Refreshes Sharrow mode-choice checkpoint.
test/regress/reference-pipeline-hh100-recode.parquetpipeline/tours/atwork_subtour_scheduling.parquet Refreshes Sharrow scheduling checkpoint.
test/regress/reference-pipeline-hh100-recode.parquetpipeline/tours/stop_frequency.parquet Refreshes Sharrow downstream checkpoint.
test/regress/reference-pipeline-hh100.parquetpipeline/tours/atwork_subtour_destination.parquet Refreshes legacy destination checkpoint.
test/regress/reference-pipeline-hh100.parquetpipeline/tours/atwork_subtour_mode_choice.parquet Refreshes legacy mode-choice checkpoint.
test/regress/reference-pipeline-hh100.parquetpipeline/tours/atwork_subtour_scheduling.parquet Refreshes legacy scheduling checkpoint.
test/regress/reference-pipeline-hh100.parquetpipeline/tours/stop_frequency.parquet Refreshes legacy downstream checkpoint.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jpn--
jpn-- merged commit 0720a17 into ActivitySim:main Aug 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants