Update regressions for corrected at-work origin TAZ - #46
Merged
jpn-- merged 1 commit intoAug 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates SANDAG regression baselines for ActivitySim’s corrected at-work subtour origin-TAZ mapping.
Changes:
- Advances the locked ActivitySim revision.
- Updates 17 affected tour destination logsums.
- Refreshes four affected checkpoints for legacy and Sharrow pipelines.
Reviewed changes
Copilot reviewed 1 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Advances ActivitySim to e23bb128. |
test/regress/final_tours.csv |
Updates affected at-work destination logsums. |
test/regress/reference-pipeline-hh100-recode.parquetpipeline/tours/atwork_subtour_destination.parquet |
Refreshes Sharrow destination checkpoint. |
test/regress/reference-pipeline-hh100-recode.parquetpipeline/tours/atwork_subtour_mode_choice.parquet |
Refreshes Sharrow mode-choice checkpoint. |
test/regress/reference-pipeline-hh100-recode.parquetpipeline/tours/atwork_subtour_scheduling.parquet |
Refreshes Sharrow scheduling checkpoint. |
test/regress/reference-pipeline-hh100-recode.parquetpipeline/tours/stop_frequency.parquet |
Refreshes Sharrow downstream checkpoint. |
test/regress/reference-pipeline-hh100.parquetpipeline/tours/atwork_subtour_destination.parquet |
Refreshes legacy destination checkpoint. |
test/regress/reference-pipeline-hh100.parquetpipeline/tours/atwork_subtour_mode_choice.parquet |
Refreshes legacy mode-choice checkpoint. |
test/regress/reference-pipeline-hh100.parquetpipeline/tours/atwork_subtour_scheduling.parquet |
Refreshes legacy scheduling checkpoint. |
test/regress/reference-pipeline-hh100.parquetpipeline/tours/stop_frequency.parquet |
Refreshes legacy downstream checkpoint. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
279e4f9atoe23bb128final_tours.csvfor the corrected at-work subtour destination logsumsRoot cause
ActivitySim PR #1094 corrected two-zone destination presampling so the configured origin MAZ is always mapped to its TAZ. For SANDAG at-work subtours, that means using the workplace TAZ instead of a stale home TAZ when computing destination logsums.
The model choices did not change, but 17 at-work
destination_logsumvalues did. One of 229 tours exceeded the final CSV comparison tolerance, causing both variants of the ActivitySim main-branch SANDAG job to fail. This PR updates the expected outputs rather than reverting the corrected mapping or weakening tolerances.Addresses ActivitySim/activitysim#1099.
Impact
No SANDAG model code, configuration, origins, destinations, or choices change. The regression data now records the corrected origin-TAZ logsums for legacy and Sharrow execution.
Validation
uv lock --checkuv run --locked pytest test/test_sandag_abm3.py -q— 2 passedgit diff --checkdestination_logsumchanged, on 17 at-work tours