fix: quicktools behaviour in read only more - #2747
Merged
Merged
Conversation
Contributor
Greptile SummaryThe PR improves read-only editor interaction by allowing unfocused cursor placement and adding one-shot Android keyboard capture for QuickTools modifier commands.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking issue identified. The new cursor placement remains guarded by CodeMirror read-only enforcement, while QuickTools capture validates its target, executes only the first normalized character, suppresses duplicate IME events, and clears or replaces pending sessions through the relevant lifecycle paths. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant QuickTools
participant Capture as ReadOnly Capture
participant Commands
participant Editor
User->>QuickTools: Activate modifier
QuickTools->>Capture: Create session for read-only view
User->>QuickTools: Type shortcut character
QuickTools->>Capture: Normalize keyboard/IME event
Capture-->>QuickTools: First character
QuickTools->>Commands: Resolve character + modifier
Commands->>Editor: Run selection-safe command
QuickTools->>Capture: Absorb duplicate IME events
QuickTools->>Editor: Keep read-only editor unfocused
Reviews (1): Last reviewed commit: "fix: quicktools behaviour in read only m..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.