Rename various accesskit and accesskit_consumer types#734
Open
PoignardAzur wants to merge 3 commits into
Open
Conversation
Rename accesskit::Tree to TreeInfo Rename accesskit_consumer::Node to accesskit_consumer::NodeRef Rename accesskit_consumer::NodeId to FullNodeId Rename accesskit_consumer::State to TreeState Because the previous names were ambiguous or had collisions, a lot of files imported them with aliases. This PR removes most of these alias imports. This is a rename-only PR with no behavior changes; most changes were done with rust-analyzer's "rename symbol" assist and similar (non-AI) tools.
DataTriny
requested changes
Jun 26, 2026
DataTriny
left a comment
DataTriny
left a comment
Member
There was a problem hiding this comment.
Please fix the intra doc links in the accesskit crate. We're clearly missing a CI check here.
accesskit::Tree is such a core type that I would prefer keeping it around for a few versions, but as a type alias:
#[deprecated]
pub type Tree = TreeInfo;Any opinion on replacing the type name by Self on impl blocks?
I haven't reviewed everything yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #720
Rename accesskit::Tree to TreeInfo
Rename accesskit_consumer::Node to accesskit_consumer::NodeRef Rename accesskit_consumer::NodeId to FullNodeId
Rename accesskit_consumer::State to TreeState
Because the previous names were ambiguous or had collisions, a lot of files imported them with aliases.
This PR removes most of these alias imports.
This is a rename-only PR with no behavior changes; most changes were done with rust-analyzer's "rename symbol" assist and similar (non-AI) tools.