Add Escape hotkey key as a workflow reset.#286
Open
tedwaine wants to merge 1 commit into
Open
Conversation
This adds an Escape hotkey that doesn the following: - stopping playback - exiting presentation mode if active - making the viewed container the inspected container - resetting the compare mode to the default for viewed container type - soloing the selection to just the single hero selected media item - leaving pinned-source mode if active In a dailies environment, when I'm done reviewing a submission I found that I needed to go through quite a few steps before moving on to the next submission. And these step often involved a cumbersome back-and-forth between mouse and keyboard. Now when I want to move on I just hit Escape and the Down arrow key. This is possibly a subjective improvement, but hopefully OK to merge since the Escape key is only currently used by the grading tool to cancel construction of a polygon mask shape. This commit includes a modification to that code so that it works when needed without doubling up. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
Contributor
|
Hi @tedwaine, one thing I wanted this feature to also do was to reset the viewport. However I couldn't find an easy way to do that from within the QML at this location. I do see that the Viewport C++ QML type supports a sendResetShortcut() signal but I don't know how to get access to the Viewport item. Any suggestions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an Escape hotkey that doesn the following:
In a dailies environment, when I'm done reviewing a submission I found that I needed to go through quite a few steps before moving on to the next submission. And these step often involved a cumbersome back-and-forth between mouse and keyboard. Now when I want to move on I just hit Escape and the Down arrow key.
This is possibly a subjective improvement, but hopefully OK to merge since the Escape key is only currently used by the grading tool to cancel construction of a polygon mask shape. This commit includes a modification to that code so that it works when needed without doubling up.