Repository navigation
Half grid type. Use raw type to avoid imposing particular conversion method. - #2335
Open
areidmeyer wants to merge 18 commits into
Open
areidmeyer wants to merge 18 commits into
areidmeyer wants to merge 18 commits into
Conversation
…method. Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
areidmeyer
marked this pull request as ready for review
September 17, 2026 22:02
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
kmuseth
approved these changes
Oct 16, 2026
kmuseth
left a comment
kmuseth
left a comment
Contributor
There was a problem hiding this comment.
looks good - thanks for making all the changes!
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
swahtz
requested changes
Oct 17, 2026
swahtz
left a comment
swahtz
left a comment
Contributor
There was a problem hiding this comment.
Just two items worth addressing. Also, please add a file in pendingchanges/ about these changes.
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
Signed-off-by: Andrew Reidmeyer <areidmeyer@nvidia.com>
swahtz
approved these changes
Oct 19, 2026
swahtz
left a comment
swahtz
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for addressing my notes
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.