Graph Editor : UX Updates Towards "Keyboardless" Workflow - #3043
Open
kwokcb wants to merge 6 commits into
Open
Conversation
- RMB add node - RMB on hamburger in node -> popup menu. Add only delete for now Fix: CTRL-F search without also trigger focus (F).
Add "rename" to menu.
- Bypass imgui node editor F key invocation which is always triggered regardless of modifiers. This is the main source of the bug.
- Disable hamburger on read-only nodes and disallow rename / delete on any read-only graphs.
- Extract out node width computation utility for us bye hamburger as well as previous pin placement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Add "Add node" :
RMBon backgroundAdd "hamburger" control :
RMBbrings up context senstive menu.Changes pan to
MMBto avoid mouse conflicts and maps properly for 2-button mice / pen / touch.LMBusage for select / placement / connection workflow is unchanged. (2)Fix so that focus (
F) does not occur when usingCTRL-F(search)Notes:
(1) Rename is in-menu to avoid constant renaming causing "flashing" in UI and slow re-render on every keystroke.
(2) the remapping of pan should make it more consistent with DCCs / Web based editors and can handle 2-button mice / touch interfaces.
Implementation
Some refactoring for code reuse as much as possible for shared actions between keyboard vs mouse actions.
Results