Align MaterialX to ASWF Color Interop Forum recommendation - #3042
Open
doug-walker wants to merge 5 commits into
Open
Align MaterialX to ASWF Color Interop Forum recommendation#3042doug-walker wants to merge 5 commits into
doug-walker wants to merge 5 commits into
Conversation
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
doug-walker
commented
Aug 17, 2026
| <?xml version="1.0"?> | ||
| <!-- | ||
| Test that a colorspace on an image and on a color4 value work. | ||
| --> |
Contributor
Author
There was a problem hiding this comment.
This is actually a trimmed-down version of color_management.mtlx. I did a git mv on that file, so I'm surprised this is showing as a new file rather than as a rename of the existing one. The original "color_management" name was effectively meaningless and so I wanted to make it more precise.
I trimmed the test down to just a few values since the new all_colorspace_names.mtlx test is where we now test that all color space names are supported.
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Contributor
Author
|
@jstone-lucasfilm, I've made the changes to the nodedefs we discussed in the Nanocolor meeting. I updated the PR description accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed at the August 11th TSC meeting, this PR brings to MaterialX full support for the ASWF Color Interop Forum recommendation Color Space Encodings for Texture Assets and CG Rendering that is used in other ASWF projects and OpenUSD. It supersedes PR #2514.
Support has been retained for all existing
colorspacenames andcmlibnodes.Per the discussion at the TSC meeting, this PR does not upgrade existing documents when reading them to use the new names, however, that is still recommended as a follow-on step. Converting to the new names would likely simplify loading of MaterialX documents into OpenUSD. As things stand with this PR, the earlier MtlX names persist into the USD representation of the material, where they won't be recognized.
PR contents:
ColorManagementSystem::isNoOpColorSpaceto manage what colorspaces are no-ops (includes unit test). Note: this will break ABI-compatibility with the current release.ColorManagementSystem::getUserFacingNameto convert the colorspace's color interop ID into a name suitable for use in a user interface.Notes:
Open questions:
transformcolornode which potentially could be useful in documents, unlike the existing cmlib nodes.