Skip to content

Fix personal video call preview and layout - #17

Merged
AbdulKus merged 1 commit into
mainfrom
feature/video-call-polish
Aug 11, 2026
Merged

Fix personal video call preview and layout#17
AbdulKus merged 1 commit into
mainfrom
feature/video-call-polish

Conversation

@AbdulKus

Copy link
Copy Markdown
Owner

What changed

  • share one EGL context between camera capture and call renderers to fix the black local preview
  • delay direct-video camera start until the tgcalls media graph is ready
  • cache video sinks and detach the local sink in picture-in-picture mode
  • align encryption emoji with the call branding row
  • account for the navigation inset in the bottom controls so active circles are not clipped
  • add subtle camera enable and switch animations

Validation

  • git diff --check
  • full ARM64 release build runs in GitHub Actions

@AbdulKus
AbdulKus marked this pull request as ready for review August 11, 2026 15:58

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd31c98a9f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1136 to +1139
localVideoWrap.animate().cancel();
localVideoWrap.animate()
.scaleX(.97f)
.scaleY(.97f)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve preview alpha when switching cameras

If the user taps the switch-camera button during the 220 ms preview appearance animation, this cancellation freezes localVideoWrap at its current alpha, while the replacement animation changes only its scale. Because localPreviewVisible is already true, subsequent state updates return without restoring the alpha, leaving the local preview partially or almost fully transparent until it is hidden and shown again.

Useful? React with 👍 / 👎.

@AbdulKus
AbdulKus merged commit adbbed1 into main Aug 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant