Support rich messages, topic read state, and automatic releases - #12
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7ccbea4c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| public boolean isCustomEmoji () { | ||
| return false; | ||
| return emoji != null; |
There was a problem hiding this comment.
When a user opens an instant-view reference whose reference text contains a custom emoji, this now identifies the entity as media, but InstantViewController.onReferenceClick builds that tooltip with a null TextMediaListener. During text preparation, Text.processEmoji calls newOrExistingMedia, which throws IllegalStateException when the listener is null, crashing the view. Supply a media listener for this tooltip or retain a non-media fallback when no listener is available.
Useful? React with 👍 / 👎.
| release: | ||
| name: Publish GitHub Release | ||
| if: github.event_name == 'push' && github.ref == 'refs/heads/main' | ||
| needs: build |
There was a problem hiding this comment.
On a main-branch push where any signing secret is absent, the build job deliberately generates a fresh ephemeral keystore, yet this unconditional main-push release job publishes that APK as the latest release. Because every such run uses a different signing identity, users who install one automatic release cannot update to the next one; gate publication on the complete signing-secret set while leaving ephemeral builds as CI artifacts only.
Useful? React with 👍 / 👎.
1 participant
Заменяет автоматически закрывшийся #11; ветка и коммит сохранены.
Что изменено
messageRichMessage: превью в чате/списке и полное содержимое во встроенном просмотрщикеSHA256SUMS.txtпосле успешной сборкиmain