Add Mini App and modern bot button support - #10
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5701c9a545
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (("http".equalsIgnoreCase(scheme) || "https".equalsIgnoreCase(scheme)) && | ||
| (!getArgumentsStrict().webAppUrl.requireSameOrigin || sameOrigin(uri))) { | ||
| return false; | ||
| } | ||
| tdlib.ui().openUrl(this, uri.toString(), new TdlibUi.UrlOpenParameters()); |
There was a problem hiding this comment.
For Mini Apps with requireSameOrigin, a cross-origin POST navigation can still load in this WebView because Android does not call shouldOverrideUrlLoading for POST requests. processSpecial is then reached from onPageFinished, where opening the URL externally does not unload the already-rendered page, leaving that foreign origin with access to the injected TelegramWebviewProxy. Replace the loaded content or otherwise enforce the origin restriction at the resource/navigation layer.
Useful? React with 👍 / 👎.
| mainButton.setVisibility(visible ? View.VISIBLE : View.GONE); | ||
| setWebViewBottomInset(visible ? Screen.dp(68f) : 0); |
There was a problem hiding this comment.
When the main button becomes visible, this inset immediately changes the WebView height, but viewport_changed is only emitted on web_app_ready or an explicit request. Consequently, Mini Apps using Telegram's viewport properties retain the old height after showing or hiding the button; rotation, IME resizing, and other later layout changes have the same problem. Observe WebView layout changes and send the updated viewport after layout settles.
Useful? React with 👍 / 👎.
| } else { | ||
| ViewUtils.setBackground(text, coloredButtonBackground(color)); | ||
| text.setTextColor(Color.WHITE); |
There was a problem hiding this comment.
Styled reply-keyboard buttons are initially assigned white text here, but every generated button remains registered with addThemeTextAccentColorListener. After a theme or auto-night transition, that listener replaces white with the normal theme text color while the hard-coded primary/danger/success background remains, producing incorrect and potentially low-contrast buttons. The theme listener needs to reapply the button's style rather than unconditionally applying the accent text color.
Useful? React with 👍 / 👎.
1 participant
Что изменено
startappи main Mini App-ссылки;web_app_data_send;primary,danger,successи custom emoji для reply-клавиатуры;Причина
TDLib уже распознавал новые Web App-типы и поля разметки, но интерфейс Frogram X явно отправлял их в unsupported/TODO.
Проверка
git diff --check— успешно;