Deprecate ImplicitNotFound, drop its use from macro engine#866
Open
halotukozak wants to merge 1 commit into
Open
Deprecate ImplicitNotFound, drop its use from macro engine#866halotukozak wants to merge 1 commit into
halotukozak wants to merge 1 commit into
Conversation
ImplicitNotFound provided composed implicit-not-found messages resolved
via implicit search. The macro engine now reads the native
@implicitNotFound annotation directly off the type symbol, so the proxy
mechanism is no longer needed.
- Deprecate ImplicitNotFound trait + apply/dummy and the notFound /
notFoundForTry proxy defs; keep them for binary compatibility.
- MacroCommons.implicitNotFoundMsg now reads native @implicitNotFound
(${T} substitution only); removed proxy lookup, replaceArgs and the
recursive overload. Native annotation has no #{param} composition, so
composed messages fall back to each type's own static message.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ImplicitNotFoundprovided composed implicit-not-found messages resolved via implicit search. The macro engine now reads the native@implicitNotFoundannotation directly off the type symbol, so the proxy mechanism is no longer needed.Changes
ImplicitNotFoundtrait +apply/dummy, and thenotFound/notFoundForTryproxy defs (MetadataCompanion,BoundedMetadataCompanion,AsRaw,AsReal). Kept for binary compatibility.MacroCommons.implicitNotFoundMsgnow reads native@implicitNotFound(${T}substitution only). RemovedImplicitNotFoundCls/ImplicitNotFoundSym, the proxy lookup,replaceArgs, and the recursive overload.ImplicitNotFoundTestto cover the native-message path throughinfer.Behavior change
Native
@implicitNotFoundhas no#{param}composition. Composed messages (Lazy[T],AsRaw/AsReal[Try]) now fall back to each type's own static native message.Verification
commons-macros+commons-corecompile clean under-Xfatal-warnings(no deprecation leak);ImplicitNotFoundTestpasses.🤖 Generated with Claude Code