Fix 3 more not-implemented crashes: import-equals and interface methods - #301
Merged
Merged
Conversation
…e methods
- mlirGenModuleReference: `import fs = require("fs")` crashed - the
function only handled QualifiedName/Identifier module references, never
ExternalModuleReference (the parser does support this syntax). tslang
compiles as one flat program with no Node.js-style require() at runtime,
so this is converted to a clean "not supported" error rather than crash.
- mlirGen(ImportEqualsDeclaration...): `import X = SomeEnum` (or any target
that isn't a namespace/class/interface) crashed the same way. Fixing the
require() crash above surfaced a second, latent bug in this same
function: the caller unwrapped mlirGenModuleReference's result with
V(result) without ever checking result.failed() first, since the callee
previously could only crash or succeed. Added the missing
EXIT_IF_FAILED(result) guard.
- addInterfaceMethod's empty-name guard: already had llvm_unreachable
immediately followed by a dead `return mlir::failure()` - the same
"crash-then-already-written-graceful-return" shape as the (confirmed
dead) UnaryBinLogicalOrHelper.h case earlier in this audit. Fixed
defensively (trivial one-line swap, location already in scope);
reachability not verified with a repro this time.
Continues the MLIRGenImpl.h/MLIRGenInterfaces.cpp/MLIRGenTypes.cpp cluster
sweep (docs/not-implemented-audit.md §4.11).
829/829 ctest, no regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of the not-implemented-audit crash-to-error sweep (follow-up to #297-#300), continuing the
MLIRGenImpl.h/MLIRGenInterfaces.cpp/MLIRGenTypes.cppcluster:mlirGenModuleReference—import fs = require("fs")crashed: the classic CommonJS/Node-interop import-equals form (a real, easily-reachable pattern in legacy TS code) was never handled. tslang compiles as one flat program with no Node.js-stylerequire()at runtime, so this is now a clean "not supported" error.mlirGen(ImportEqualsDeclaration...)—import X = SomeEnum(or any target that isn't a namespace/class/interface) crashed the same way. Fixing therequire()crash above surfaced a second, latent bug in the same function: the caller unwrapped the callee's result without checking.failed()first, since the callee previously could only crash or succeed. Added the missingEXIT_IF_FAILEDguard.addInterfaceMethod's empty-name guard — already hadllvm_unreachableimmediately followed by a deadreturn mlir::failure(), the same pattern as an earlier confirmed-dead case in this audit. Fixed defensively (trivial,locationalready in scope); reachability not verified with a repro this time.docs/not-implemented-audit.mdupdated with the full writeup (§4.11), including a general lesson for the rest of this audit: converting a crash toreturn mlir::failure()can surface a second bug one level up in a caller that never had to handle a graceful failure before — always re-run the specific repro, not just the full suite.Test plan
import fs = require("fs"),import C = SomeEnum) verified: clean diagnostics, no crashctest -C Debug -j8→ 829/829, no regressions🤖 Generated with Claude Code