Extend cross-module coverage: boxed untyped-export with multiple methods - #264
Merged
Merged
Conversation
export_object_literal_untyped.ts only ever exercised a single method (inc()) on a boxed ObjectType import. Adds a genuinely multi-method variant (add/ addTwice/scaled), covering both direct calls on the boxed global and an interface cast of it - a combination only made correct by the decl-text object-vs-tuple printer fix (#263), not previously tested. 736/736 suite. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
export_object_literal_untyped.tsonly ever exercised a single method (inc()) on a boxedObjectTypecross-module import. This combination (boxed dynamic import + multiple method fields) was untested even after Fix cross-module multi-method vtable corruption via decl-text object-vs-tuple printing #263's decl-text printer fix, which is what actually makes multi-method fields round-trip correctly at all.export/import_object_literal_untyped_multi_method.ts: a 3-method (add/addTwice/scaled) untyped export, exercising both direct calls on the boxed global and an interface cast of it in the importer.Test plan
🤖 Generated with Claude Code