Skip to content

Fix llvm_unreachable aborts resolving unknown field/method names in getFieldTypeByFieldName #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ASDAlexander77 merged 3 commits into from
Jul 15, 2026
Merged

Fix llvm_unreachable aborts resolving unknown field/method names in getFieldTypeByFieldName #238

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e028a6d
Fix llvm_unreachable abort when resolving non-data-field names on arr…
ASDAlexander77 Jul 15, 2026
036868c
Fix remaining llvm_unreachable aborts in getFieldTypeByFieldName
ASDAlexander77 Jul 15, 2026
c6b99eb
Fix getFieldTypeByFieldName looking up ClassType in the interfaces table
ASDAlexander77 Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions tslang/include/TypeScript/MLIRLogic/MLIRTypeHelper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2314,10 +2314,6 @@ class MLIRTypeHelper
{
return methodInfo->funcType;
}
else
{
llvm_unreachable("not implemented");
}
}
}

Expand All @@ -2326,12 +2322,13 @@ class MLIRTypeHelper

if (auto srcClassType = dyn_cast<mlir_ts::ClassType>(srcType))
{
if (auto srcClassInfo = getInterfaceInfoByFullName(srcClassType.getName().getValue()))
if (auto srcClassInfo = getClassInfoByFullName(srcClassType.getName().getValue()))
{
auto fieldInfo = srcClassInfo->findField(fieldName);
if (fieldInfo)
auto foundField = false;
auto fieldInfo = srcClassInfo->findField(fieldName, foundField);
if (foundField)
{
return fieldInfo->type;
return fieldInfo.type;
}

if (auto strName = dyn_cast<mlir::StringAttr>(fieldName))
Expand All @@ -2341,10 +2338,6 @@ class MLIRTypeHelper
{
return methodInfo->funcType;
}
else
{
llvm_unreachable("not implemented");
}
}
}

Expand Down Expand Up @@ -2372,8 +2365,9 @@ class MLIRTypeHelper
return mlir_ts::AnyType::get(context);
}

llvm_unreachable("not implemented");
}
// any other field (e.g. an extension method name like "push"/"pop") is not a data field of the array
return mlir::Type();
}

// TODO: read fields info from class Array
if (auto constArrayType = dyn_cast<mlir_ts::ConstArrayType>(srcType))
Expand All @@ -2389,8 +2383,9 @@ class MLIRTypeHelper
return mlir_ts::AnyType::get(context);
}

llvm_unreachable("not implemented");
}
// any other field (e.g. an extension method name like "push"/"pop") is not a data field of the array
return mlir::Type();
}

// TODO: read data from String class
if (auto stringType = dyn_cast<mlir_ts::StringType>(srcType))
Expand All @@ -2400,8 +2395,9 @@ class MLIRTypeHelper
return mlir_ts::NumberType::get(context);
}

llvm_unreachable("not implemented");
}
// any other field (e.g. a method name like "fromCharCode"/"charAt") is not a data field of String
return mlir::Type();
}

if (auto unionType = dyn_cast<mlir_ts::UnionType>(srcType))
{
Expand Down
Loading