Skip to content

Fix segfault in declaration-export type walker on unregistered types #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ASDAlexander77 merged 1 commit into from
Jul 15, 2026
Merged

Fix segfault in declaration-export type walker on unregistered types #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 28 additions & 7 deletions tslang/lib/TypeScript/MLIRGenImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9842,7 +9842,11 @@ class MLIRGenImpl
auto cont = mlir::TypeSwitch<mlir::Type, bool>(type)
.Case<mlir_ts::InterfaceType>([&](auto ifaceType) {
auto interfaceInfo = getInterfaceInfoByFullName(ifaceType.getName().getValue());
assert(interfaceInfo);
if (!interfaceInfo)
{
// not registered (e.g. forward/ambient reference), nothing to export
return true;
}

for (auto& method : interfaceInfo->methods)
{
Expand All @@ -9858,7 +9862,11 @@ class MLIRGenImpl
})
.Case<mlir_ts::ClassType>([&](auto classType) {
auto classInfo = getClassInfoByFullName(classType.getName().getValue());
assert(classInfo);
if (!classInfo)
{
// not registered (e.g. forward/ambient reference), nothing to export
return true;
}

for (auto& method : classInfo->methods)
{
Expand Down Expand Up @@ -9903,20 +9911,33 @@ class MLIRGenImpl
auto cont = mlir::TypeSwitch<mlir::Type, bool>(type)
.Case<mlir_ts::InterfaceType>([&](auto ifaceType) {
auto interfaceInfo = getInterfaceInfoByFullName(ifaceType.getName().getValue());
assert(interfaceInfo);
if (!interfaceInfo)
{
// not registered (e.g. forward/ambient reference), nothing to export
return true;
}

addInterfaceDeclarationToExport(interfaceInfo);
return true;
})
.Case<mlir_ts::ClassType>([&](auto classType) {
auto classInfo = getClassInfoByFullName(classType.getName().getValue());
assert(classInfo);
if (!classInfo)
{
// not registered (e.g. forward/ambient reference), nothing to export
return true;
}

addClassDeclarationToExport(classInfo);
return true;
})
.Case<mlir_ts::EnumType>([&](auto enumType) {
auto enumInfo = getEnumInfoByFullName(enumType.getName().getValue());
assert(enumInfo);
assert(enumInfo->enumType == enumType);
if (!enumInfo || enumInfo->enumType != enumType)
{
// not registered (e.g. forward/ambient reference), nothing to export
return true;
}

addEnumDeclarationToExport(enumInfo->name, enumInfo->elementNamespace, enumType);
return true;
Expand All @@ -9926,7 +9947,7 @@ class MLIRGenImpl
});

return cont;
}
}

void addTypeDeclarationToExport(StringRef name, NamespaceInfo::TypePtr elementNamespace, mlir::Type type)
{
Expand Down
Loading