Skip to content

include auth state in cache key to prevent stale data after adding PAT (#228) #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KaizenPrad wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −2
Open

include auth state in cache key to prevent stale data after adding PAT (#228) #229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f6d932
fix: include auth state in cache key to prevent stale data after addi…
KaizenPrad Sep 10, 2026
75766e5
fix: use PAT hash in cache key instead of generic ::auth suffix
KaizenPrad Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/services/github.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,24 @@ export async function cacheClear() {
} catch { return false }
}

// Hash a PAT to a short non-secret identifier for cache keying (fixes #228)
function hashPAT(pat) {
let h = 0
for (let i = 0; i < pat.length; i++) {
h = ((h << 5) - h + pat.charCodeAt(i)) | 0
}
return (h >>> 0).toString(36)
}

// Core fetchWithCache
async function fetchWithCache(url, pat) {
// Include a non-secret per-identity hash in the cache key so each
// unique PAT gets its own cache entries, without storing the raw
// token in IndexedDB (fixes #228, addresses CodeRabbit CWE-524)
const cacheKey = pat ? `${url}::${hashPAT(pat)}` : url

// L2 check
const cached = await cacheGet(url)
const cached = await cacheGet(cacheKey)
if (cached) return cached

const headers = { Accept: 'application/vnd.github.v3+json' }
Expand All @@ -78,7 +92,7 @@ async function fetchWithCache(url, pat) {
if (!res.ok) throw new Error(`HTTP_${res.status}`)

const data = await res.json()
cacheSet(url, data) // write-back, non-blocking
cacheSet(cacheKey, data) // write-back, non-blocking
return data
}

Expand Down
Loading