Skip to content

fix: handle non-array GitHub API responses #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Roshnicoderr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: handle non-array GitHub API responses #226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c94d403
fix: handle non-array GitHub API responses
Sep 9, 2026
efb4d09
fix: cache empty 204 responses
Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/services/github.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ async function fetchWithCache(url, pat) {
if (res.status === 403) throw new Error('RATE_LIMIT')
if (res.status === 404) throw new Error('NOT_FOUND')
if (!res.ok) throw new Error(`HTTP_${res.status}`)

if(res.status==204){
cacheSet(url, [])
return[]
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const data = await res.json()
cacheSet(url, data) // write-back, non-blocking
return data
Expand Down Expand Up @@ -104,6 +107,7 @@ export async function fetchContributors(org, repo, pat) {
for(let page = 1; page<=maxPages ; page++) {
const url = `https://api.github.com/repos/${org}/${repo}/contributors?per_page=100&page=${page}`
const data = await fetchWithCache(url, pat)
if (!Array.isArray(data)) break
all.push(...data)
if(data.length < 100) break
}
Expand All @@ -116,6 +120,7 @@ export async function fetchIssues(org, repo, pat) {
for(let page = 1; page<=maxPages ; page++) {
const url = `https://api.github.com/repos/${org}/${repo}/issues?state=all&per_page=100&page=${page}`
const data = await fetchWithCache(url, pat)
if (!Array.isArray(data)) break
all.push(...data)
if(data.length < 100) break
}
Expand All @@ -128,6 +133,7 @@ export async function fetchPulls(org, repo, pat) {
for(let page = 1; page<=maxPages ; page++) {
const url = `https://api.github.com/repos/${org}/${repo}/pulls?state=all&per_page=100&page=${page}`
const data = await fetchWithCache(url, pat)
if (!Array.isArray(data)) break
all.push(...data)
if(data.length < 100) break
}
Expand Down
Loading