Skip to content

arm64: dts: Remove GPIO10 espi_default gpio-hog #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankitaprasad2206 wants to merge 1 commit into
base: dev-a2
Choose a base branch
from
Open

arm64: dts: Remove GPIO10 espi_default gpio-hog #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions arch/arm64/boot/dts/aspeed/aspeed-bmc-amd-ghana.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,12 +694,6 @@ pmic_ ## bus ## _ ## index: pmic@addr{ \

&gpio0 {

@mahkurap mahkurap Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we want to merge this change to dev-a2 branch which hosts only Arthur related changes? I think you want this to be merged to dev_6.18.20 branch. please check.

@ankitaprasad2206 ankitaprasad2206 Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge in dev_6.18.20. thanks for pointing out

status = "okay";
espi_default {
gpio-hog;
gpios = <10 GPIO_ACTIVE_HIGH>;
output-low;
line-name = "espiboot_pin_default";

@mahkurap mahkurap Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why dont we need to do similar changes for other platforms? I see that the same line-name is defined in Congo dts, but in gpio1. Is there a specific reason?

@rajaganeshr rajaganeshr Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpio-hog was added earlier during bringup on all dts, and later removed. Ghana and Nigeria missed it.
This gpio is initialized in platform-init based on QSPI or eSPI variant detected.

@mahkurap mahkurap Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajaganeshr we are missing something here. integ_sp8 has the definition of gpio0 with the gpio-hog deleted. https://github.com/AMDESE/linux-aspeed/blob/integ_sp8/arch/arm64/boot/dts/aspeed/aspeed-bmc-amd-congo.dts#L978. dev_6.18.20 has the gpio1 defined with gpio-hog. https://github.com/AMDESE/linux-aspeed/blob/integ_sp8/arch/arm64/boot/dts/aspeed/aspeed-bmc-amd-congo.dts#L978. Please check. I noticed this discrepancy in the Congo device tree. Not sure where we got deviated. Please check, and also we may want to check all the other device trees in the dev_6.18.20 branch for consistency.

};

/*
* by default the direction of the SEL_P0_SEC_I2C_ROT_BMC (GPIO B0)
Expand Down
6 changes: 0 additions & 6 deletions arch/arm64/boot/dts/aspeed/aspeed-bmc-amd-nigeria.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,12 +888,6 @@ pmic_ ## bus ## _ ## index: pmic@addr{ \

&gpio0 {
status = "okay";
espi_default {
gpio-hog;
gpios = <10 GPIO_ACTIVE_HIGH>;
output-low;
line-name = "espiboot_pin_default";
};

/*
* by default the direction of the SEL_P0_SEC_I2C_ROT_BMC (GPIO B0)
Expand Down