Fix DeepSeek4HyperHead instantiation and usage in NNXDecoder - #4782
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the Google Cloud CLI to the agent sidecar Dockerfile, increases the retry count and sleep duration for Gemini API calls, adds a mock failure log, and removes DeepSeek4-specific hyper-head logic from the NNX decoders. Feedback recommends using HTTPS and curl -fsSL for downloading the Google Cloud SDK keyring to ensure secure and reliable package installation, and updating the docstring in adk_agent.py to match the new 60-second default sleep time.
| echo "deb [signed-by=/usr/share/keyrings/cloud.google.gpg] http://packages.cloud.google.com/apt cloud-sdk main" | tee -a /etc/apt/sources.list.d/google-cloud-sdk.list && \ | ||
| curl https://packages.cloud.google.com/apt/doc/apt-key.gpg | gpg --dearmor -o /usr/share/keyrings/cloud.google.gpg && \ | ||
| apt-get update && apt-get install -y gh google-cloud-cli && \ |
There was a problem hiding this comment.
Use https instead of http for the Google Cloud SDK apt repository to ensure secure package metadata transport. Additionally, use curl -fsSL to ensure that any download failures are propagated and do not silently result in an invalid or empty keyring file.
echo "deb [signed-by=/usr/share/keyrings/cloud.google.gpg] https://packages.cloud.google.com/apt cloud-sdk main" | tee -a /etc/apt/sources.list.d/google-cloud-sdk.list && \
curl -fsSL https://packages.cloud.google.com/apt/doc/apt-key.gpg | gpg --dearmor -o /usr/share/keyrings/cloud.google.gpg && \
apt-get update && apt-get install -y gh google-cloud-cli && \
|
|
||
|
|
||
| def _send_message_with_retry(chat, prompt, max_retries=3, sleep_seconds=30): | ||
| def _send_message_with_retry(chat, prompt, max_retries=5, sleep_seconds=60): |
There was a problem hiding this comment.
The default value of sleep_seconds has been updated from 30 to 60, but the docstring on the following line still states: Sends a message to Gemini with retry and a 30-second sleep.... Please update the docstring to reflect the new 60-second default sleep time to keep the documentation accurate.
1 participant
Fix DeepSeek4HyperHead instantiation and usage in NNXDecoder