-
Notifications
You must be signed in to change notification settings - Fork 582
qwen3 muon fork #4779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shuwen-Fang
wants to merge
12
commits into
AI-Hypercomputer:main
Choose a base branch
from
Shuwen-Fang:shuwen-qwen3-muon
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
qwen3 muon fork #4779
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cbcaaeb
Update qwen3-next-80b-a3b.yml config parameters
darisoy 00302b2
Integrate mHC into Qwen3NextDecoderLayer (mhc_expansion_rate=4)
darisoy 0360d02
Implement Newton-Schulz log-depth custom VJP triangular matrix solver…
darisoy 4960fea
Implement Hybrid GDN v3 Tokamax forward + Newton-Schulz Custom VJP ba…
darisoy 78d09f4
feat: implement Muon optimizer support for Qwen3-Next architecture (R…
darisoy 1476823
add scan support for qwen3-next model
NuojCheng c5ef832
add muon impl
Shuwen-Fang 056abb1
integrate muon
Shuwen-Fang a9a6b33
use adamw instead of muon for expert weights
Shuwen-Fang 6506eba
explicitly_weight_ag for shard exp on fsdp
Shuwen-Fang 36efee5
update default nesterov style
Shuwen-Fang 589cd74
apply muon to expert weights and update optimizer config
Shuwen-Fang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
385 changes: 233 additions & 152 deletions
385
src/maxtext/checkpoint_conversion/utils/param_mapping.py
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
scan_layersis enabled and there are remainder layers, they are instantiated without an explicitname. Flax Linen will auto-name them (e.g.,Qwen3NextDecoderLayerToLinen_0), which will mismatch the expected prefixparams-decoder-layers_{layer_id}inparam_mapping.py. Specifyingname=f"layers_{layer_id}"ensures the parameter names are consistent and checkpoint conversion works correctly.