Skip to content

fix(pylint): ignore datasets module to resolve E0611 no-name-in-module errors #4750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NuojCheng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pylint): ignore datasets module to resolve E0611 no-name-in-module errors #4750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ repos:
- id: pylint
args:
- '--disable=R0401,R0917,W0201,W0613'
- '--ignored-modules=datasets'
Comment on lines 31 to +32

@gemini-code-assist gemini-code-assist Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of passing --ignored-modules=datasets as a command-line argument in the pre-commit configuration, it is highly recommended to add this configuration directly to the pylintrc file.

Centralizing pylint configuration in pylintrc ensures that the same rules and ignores are applied consistently across all environments, including local IDE integrations and manual CLI runs, rather than only during pre-commit hooks.

You can configure this in pylintrc under the [TYPECHECK] section:

[TYPECHECK]
ignored-modules=datasets
          - '--disable=R0401,R0917,W0201,W0613'

- "--ignore-patterns='.pytype,.*pyi$'"
- '--ignore-paths=src/maxtext/input_pipeline/protos|src/maxtext/eval/simple_evals_template'

Expand Down
Loading