Add eval_start_step flag and allow evaluation from step 0#4547
Open
zxhe-sean wants to merge 1 commit into
Open
Add eval_start_step flag and allow evaluation from step 0#4547zxhe-sean wants to merge 1 commit into
zxhe-sean wants to merge 1 commit into
Conversation
zxhe-sean
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025,
vipannalla and
xibinliu
as code owners
July 20, 2026 23:10
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
RissyRan
reviewed
Jul 20, 2026
RissyRan
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the change!
zxhe-sean
force-pushed
the
zxhe/eval_start_step
branch
from
July 22, 2026 00:03
0b02891 to
c48f9d3
Compare
zxhe-sean
force-pushed
the
zxhe/eval_start_step
branch
from
July 22, 2026 21:51
c48f9d3 to
d2f0052
Compare
RissyRan
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds full support for the
eval_start_stepconfiguration flag in MaxText to delay or control when interval-based evaluations trigger during pre-training, and updates the evaluation step check fromstep > start_steptostep >= start_step.Why is this change being made
eval_start_step: The need of the delay is coming from the new validation requirement of MLPerfstart_step(step >= start_step): The evaluation condition previously checkedstep > start_step, strictly preventing evaluations from firing on the very first step (step == start_step), such as whenstart_step = 0andeval_interval = 1. Updating this tostep >= start_stepallows evaluation to fire on step 0 or the starting step when configured.FIXES: b/535641549
Tests
When setting
eval_start_step=10, the log shows the eval started at step 10: https://fusion2.corp.google.com/invocations/f6ea1094-7d28-4c76-be75-f0bbaeb9ac5d/logThe eval now can start from step 0: https://fusion2.corp.google.com/invocations/7cb76b6f-e36e-4ba7-ab17-aa90a9e1c6e6/log
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.